Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Reactions visualization #4138

Closed
johnsoncodehk opened this issue Mar 21, 2024 · 4 comments
Closed

[Feature] Reactions visualization #4138

johnsoncodehk opened this issue Mar 21, 2024 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@johnsoncodehk
Copy link
Member

Refs https://github.com/HalfdanJ/svelte-reactions, https://twitter.com/halfdanj/status/1658166562660941824

@johnsoncodehk johnsoncodehk added the enhancement New feature or request label Mar 21, 2024
@johnsoncodehk johnsoncodehk added this to the v2.1 milestone Mar 21, 2024
@rchl
Copy link
Collaborator

rchl commented Mar 21, 2024

Just based on the gif it looks to me like the standard document highlight that just highlights references of the current variable.

Possibly in some other cases it does a bit extra but I feel like it could be easily confused for document highlights if implemented.

@mrleblanc101
Copy link

I think he is talking about the green line highlight and not the gray variable highlight.
preview

@rchl
Copy link
Collaborator

rchl commented Mar 21, 2024

Right, I see.

@johnsoncodehk johnsoncodehk changed the title [Feature] Implement reaction visualization [Feature] Reactions visualization Mar 24, 2024
@johnsoncodehk
Copy link
Member Author

johnsoncodehk commented Mar 25, 2024

Implement by https://github.com/volarjs/insiders/pull/5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants