Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Automatically enable Hybrid Mode #4131

Closed
johnsoncodehk opened this issue Mar 20, 2024 · 3 comments · Fixed by #4206
Closed

[Feature] Automatically enable Hybrid Mode #4131

johnsoncodehk opened this issue Mar 20, 2024 · 3 comments · Fixed by #4206
Labels
enhancement New feature or request

Comments

@johnsoncodehk
Copy link
Member

johnsoncodehk commented Mar 20, 2024

Hybrid Mode can be disabled after 2.0.7 and is disabled by default. We can detect and automatically enable it under specific conditions to improve performance.

Automatic activation should meet the following conditions:

  1. VSCode version >= 1.88 This will be the installation condition for the extension
  2. No other extensions with TS plugin are installed Only the TS plugin extensions in the whitelist are installed
  3. TS version >= 5.3
@johnsoncodehk johnsoncodehk added the enhancement New feature or request label Mar 20, 2024
@johnsoncodehk johnsoncodehk added this to the v2.1 milestone Mar 20, 2024
@catgoose
Copy link

What about neovim?

@segevfiner
Copy link
Contributor

Might want to also consider having a whitelist of known TS server plugins that will not prevent automatic activation. Intellicode is pretty common for example due to Microsoft pushing it in many extension packs. And I also have the MDX one installed and working fine.

@johnsoncodehk johnsoncodehk changed the title [Feature Request] Automatically enable Hybrid Mode [Feature] Automatically enable Hybrid Mode Mar 21, 2024
@johnsoncodehk johnsoncodehk removed this from the v2.1 milestone Apr 4, 2024
@johnsoncodehk
Copy link
Member Author

@segevfiner good point, will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants