Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Drag and Drop Component Import respects tsconfig path aliases #4125

Closed
johnsoncodehk opened this issue Mar 20, 2024 · 2 comments · Fixed by #4184
Closed

[Feature] Drag and Drop Component Import respects tsconfig path aliases #4125

johnsoncodehk opened this issue Mar 20, 2024 · 2 comments · Fixed by #4184
Labels
enhancement New feature or request

Comments

@johnsoncodehk
Copy link
Member

When tsconfig is configured with "paths": { "@/*": ["src/*"] }, drag /src/components/HelloWorld.vue into /src/App.vue and it should be imported @/components/HelloWorld.vue instead of ./components/HelloWorld.vue.
@johnsoncodehk johnsoncodehk added the enhancement New feature or request label Mar 20, 2024
@johnsoncodehk johnsoncodehk added this to the v2.1 milestone Mar 20, 2024
@johnsoncodehk johnsoncodehk changed the title [Feature Request] Drag and Drop Component Import respects tsconfig path aliases [Feature] Drag and Drop Component Import respects tsconfig path aliases Mar 21, 2024
@newVincentFong
Copy link

I'm trying to implement this feature.
How is it supposed to access tsconfig inside a volar language service ?
I didn't find anything useful in the context object.
Maybe it involves some changes of volar.js project ?
@johnsoncodehk

johnsoncodehk added a commit that referenced this issue Mar 30, 2024
@johnsoncodehk
Pre-work for #4125
74c3e85
@johnsoncodehk
Copy link
Member Author

@newVincentFong You can start with 74c3e85.

The main operations are located at 74c3e85#diff-1754a4c09f9ad2611310f617ea9e28f2e060a76f8b1515158ee60c04d198a86fR12.

@johnsoncodehk johnsoncodehk removed this from the v2.1 milestone Mar 30, 2024
@johnsoncodehk johnsoncodehk mentioned this issue Mar 31, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(language-service): drag and drop import respects tsconfig path aliases vuejs/language-tools
2 participants
@johnsoncodehk @newVincentFong