Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n, 404 section #2560

Open
skiff26 opened this issue Nov 3, 2023 · 7 comments
Open

i18n, 404 section #2560

skiff26 opened this issue Nov 3, 2023 · 7 comments
Assignees
Labels
bug Errors and issues people encounter with the docs / repo

Comments

@skiff26
Copy link

skiff26 commented Nov 3, 2023

Description

When you try to go from a page on vuejs.org to ua.vuejs.org and pt.vuejs.org, like this one - https://vuejs.org/guide/essentials/application.html, you'll run into an error. I only noticed this in the docs section. It only works if you didn't change pages before trying to switch to the UA/PT version.

image
image

The same problem has it.vuejs.org, an error section appears.

image

@brc-dd
Copy link
Member

brc-dd commented Nov 3, 2023

I think those don't have an updated vitepress version or maybe some configuration issue at their netlify/vercel. It seems to be working fine for french, chinese, japanese, korean, bangla. Only ua, pt, it have issues IG.

@brc-dd brc-dd added bug Errors and issues people encounter with the docs / repo help wanted When you need help with how to solve the issue, use this label. and removed help wanted When you need help with how to solve the issue, use this label. labels Nov 3, 2023
@brc-dd brc-dd self-assigned this Nov 6, 2023
@brc-dd
Copy link
Member

brc-dd commented Nov 6, 2023

seems to be a bug in theme - https://github.com/vuejs/theme/blob/main/src/vitepress/components/VPNavBarLocaleItems.vue#L18 (normalization should be done here and probably should use page.relativePath instead)

@skiff26
Copy link
Author

skiff26 commented Nov 6, 2023

So, do I need to recreate this issue in the vuejs/theme?

@brc-dd
Copy link
Member

brc-dd commented Nov 6, 2023

No need. I'll update both.

@skirtles-code
Copy link
Contributor

I think #2664 is related.

@brc-dd
Copy link
Member

brc-dd commented Jan 14, 2024

Yeah, sorry. I actually forgot about this. I'll fix the theme. I don't think any of the translations sites are using cleanUrls, so that vercel fix should work fine too 👀

@Jinjiang
Copy link
Member

Same issue as vuejs-translations/docs-pt#128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Errors and issues people encounter with the docs / repo
Projects
None yet
Development

No branches or pull requests

4 participants