New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(custom-element): Use asynchronous custom element nesting to avoid errors #9351
base: main
Are you sure you want to change the base?
Conversation
Size ReportBundles
Usages
|
Co-authored-by: edison <[email protected]>
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
also fix #8127 |
@baiwusanyu-c |
I will take the time to check the issue |
CodSpeed Performance ReportMerging #9351 will improve performances by 73.58%Comparing Summary
Benchmarks breakdown
|
Is your problem that |
@baiwusanyu-c Yes, the shadowroot of the custom element is staying empty, without the patch it is working |
try again @yashha |
@baiwusanyu-c But in our project we have now bad performance in dev mode, we run in some kind of loop, I don't know whats the cause. I get several of these:
|
It was something on our side, we had a component without template tags only script tags, that caused the issue. |
It should be that references cause memory usage. I will consider how to solve this problem. |
# Conflicts: # packages/runtime-dom/__tests__/customElement.spec.ts
Hello @baiwusanyu-c and @edison1105 , Could you please review this and merge if possible? We ran into this issue as well, when wc imports wc within the slot. Thank you, |
Hello @baiwusanyu-c @edison1105 @yyx990803 @LinusBorg , I am so sorry for bothering you all, but could you please take a look to see if this could be merged, and if so, please merge it? We are waiting on this PR. Thank you again for all your great work, |
close: #9341
close: #8127