Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(custom-element): fix that boolean prop with default true can't updated to falsy value #12215

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(custom-element): fix that boolean prop with default true can't updated to falsy value #12215

wants to merge 2 commits into from

Conversation

lejunyang
Copy link

close #12214

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 20, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+166 B) 38 kB (+38 B) 34.2 kB (+86 B)
vue.global.prod.js 159 kB (+166 B) 57.9 kB (+43 B) 51.4 kB (-57 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.9 kB (+166 B) 22.9 kB (+48 B) 20.8 kB (-26 B)
overall 68.7 kB 26.3 kB 24 kB

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 20, 2024 •
edited
Loading

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12215

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12215

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12215

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12215

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12215

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12215

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12215

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12215

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12215

vue

pnpm add https://pkg.pr.new/vue@12215

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12215

commit: 9cd4dda

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: custom elements 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Oct 21, 2024
@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Oct 21, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools ✅ success ✅ success
nuxt ❌ failure ✅ success
pinia ✅ success ✅ success
primevue ✅ success ✅ success
quasar ✅ success ✅ success
radix-vue ✅ success ✅ success
router ✅ success ✅ success
test-utils ✅ success ✅ success
vant ✅ success ✅ success
vite-plugin-vue ✅ success ✅ success
vitepress ✅ success ✅ success
vue-i18n ✅ success ✅ success
vue-macros ✅ success ✅ success
vuetify ✅ success ✅ success
vueuse ✅ success ✅ success
vue-simple-compiler ✅ success ✅ success

@edison1105
Copy link
Member

/ecosystem-ci run nuxt

@vue-bot
Copy link
Contributor

vue-bot commented Oct 21, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
nuxt ✅ success ✅ success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: custom elements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In Vue custom element, Boolean prop with default true cannot be updated to falsy value
3 participants
@lejunyang @edison1105 @vue-bot