Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3 support #21

Open
martinschaer opened this issue Nov 26, 2021 · 3 comments
Open

Vue 3 support #21

martinschaer opened this issue Nov 26, 2021 · 3 comments

Comments

@martinschaer
Copy link

Hi!

I forked this to make it compatible with Vue 3 + TS on my current project. I need to clean it up a bit to send a PR, but first I wanted to know if there are any thoughts about this.

Thanks!

@martinschaer
Copy link
Author

One thought to start: I would avoid overloading prop types like favicon (string or boolean) and storage (string or object). I actually had to avoid this to make it work with TypeScript.

More about this in point 5 –Don't Overload Your Prop Types– on this article: https://michaelnthiessen.com/unlock-full-potential-prop-types/

@ktquez
Copy link
Member

ktquez commented Nov 26, 2021

@martinschaer

Awesome!
We will be grateful to receive your support in this.

@ItsRainingHP
Copy link

I wanted to use this package and it took me so long to figure out its not Vue 3 capable. Back to the search for a Vue 3 dark mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants