Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert assigning reviewer to GitHub Actions #262

Open
tetsuharuohzeki opened this issue Jan 5, 2019 · 2 comments
Open

Convert assigning reviewer to GitHub Actions #262

tetsuharuohzeki opened this issue Jan 5, 2019 · 2 comments

Comments

@tetsuharuohzeki
Copy link
Contributor

  • I seem GitHub Actions would be reasonable way to change label & reviewers.
  • GitHub Actions is still public beta and there are some limitations. We cannot remove it immediately after we convert assigning reviewer to GitHub Actions.

Related Issues

@tetsuharuohzeki
Copy link
Contributor Author

I'm trying this in my private project, but the latency of GitHub Actions is still high. It does not react in a real time (It need ~30s to complete changing label including launch actions).

@tetsuharuohzeki
Copy link
Contributor Author

I worked and open sourced these actions in my previous job:

  • detect-unmergeable
    • I think popuko's unmergeable detection might be replaced with this action.
    • But there might be a problem about a latency which this action comments after the trunk is changed. popuko's one is tightly coupled with their merge queue. This kind of latency problem is rare case.
  • auto-assign by comment
    • This command parser is fully scratched with JS but the base design is shared with popuko.
    • This parser has new syntax like r? userA || userB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant