Prevent "Unbalanced parenthesis" error when aligning parameters

Author: smoeding

puppet-mode.el

@@ -1041,6 +1041,12 @@ Used as `syntax-propertize-function' in Puppet Mode."
   "Align the current block."
   (interactive)
   (save-excursion
+    ;; Move point after the end of the string if inside a string to
+    ;; prevent "Unbalanced parentheses" error by `backward-up-list'.
+    (let ((region (puppet-string-region)))
+      (when region
+        (goto-char (nth 1 region))
+        (forward-char)))
     (backward-up-list)
     (let ((beg (point)))
       (forward-list)

test/puppet-mode-test.el

@@ -615,6 +615,32 @@ class foo {
   }
 }"))))
 
+(ert-deftest puppet-align-block/point-in-string ()
+  :tags '(alignment)
+   (puppet-test-with-temp-buffer
+      "
+class foo {
+  $x = {
+    'a'=>1,
+    'foo'=>{
+      'apples'=>1,
+    },
+    'metafalica'=>1,
+  }
+}"
+    (search-forward "tafalica")
+    (puppet-align-block)
+    (should (string= (buffer-string) "
+class foo {
+  $x = {
+    'a'          => 1,
+    'foo'        => {
+      'apples'=>1,
+    },
+    'metafalica' => 1,
+  }
+}"))))
+
 
 ;;;; Imenu