Skip to content

[FR] Let fiftyone.core.video.make_frames_dataset take kwargs for ffmpeg. #5612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 6 tasks
bhoo-git opened this issue Mar 19, 2025 · 0 comments
Open
2 of 6 tasks
Labels
feature Work on a feature request

Comments

@bhoo-git
Copy link

Proposal Summary

The fiftyone.core.video.make_frames_dataset function uses the fiftyone.utils.video.sample_videos function under the hood. The fiftyone.utils.video.sample_videos function can take keyword arguments for eta.core.video.FFmpeg(**kwargs). It would be nice to have fiftyone.core.video.make_frames_dataset also be able to take keyword arguments and have it feed the FFmpeg args downstream.

Motivation

  • What is the use case for this feature? Making the image datasets from videos more streamlined.
  • Why is this use case valuable to support for FiftyOne users in general? It gives more flexibility to the user when creating image dataset(s) from frames of video(s) within the existing function use case.
  • Why is this use case valuable to support for your project(s) or organization? I expect to get raw videos and want to store the frames in a FiftyOneDataset format as a part of my workflow.
  • Why is it currently difficult to achieve this use case? Without the keyword arguments, the frames are automatically stored as a .jpg extensions and sometimes the image quality suffers from the compression.

What areas of FiftyOne does this feature affect?

  • App: FiftyOne application
  • Core: Core fiftyone Python library
  • Server: FiftyOne server

Details

It would be a pretty simple change in my opinion, would just have to let make_frames_dataset take **kwargs and have it fed into the fouv.sample_videos.

Willingness to contribute

The FiftyOne Community welcomes contributions! Would you or another member of your organization be willing to contribute an implementation of this feature?

  • Yes. I can contribute this feature independently
  • Yes. I would be willing to contribute this feature with guidance from the FiftyOne community
  • No. I cannot contribute this feature at this time
@bhoo-git bhoo-git added the feature Work on a feature request label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on a feature request
Projects
None yet
Development

No branches or pull requests

1 participant