Merge pull request #107 from voxel51/bugfix/ids

Updating add_sample_field() usage

Author: brimoor

fiftyone/brain/internal/core/similarity.py

@@ -587,21 +587,15 @@ def duplicates_view(
     dups_view = samples.select(ids, ordered=True)
 
     if type_field is not None:
-        dups_view._dataset._add_sample_field_if_necessary(
-            type_field, fof.StringField
-        )
+        dups_view._dataset.add_sample_field(type_field, fof.StringField)
         dups_view.set_values(type_field, types)
 
     if id_field is not None:
-        dups_view._dataset._add_sample_field_if_necessary(
-            id_field, fof.StringField
-        )
+        dups_view._dataset.add_sample_field(id_field, fof.StringField)
         dups_view.set_values(id_field, nearest_ids)
 
     if dist_field is not None:
-        dups_view._dataset._add_sample_field_if_necessary(
-            dist_field, fof.FloatField
-        )
+        dups_view._dataset.add_sample_field(dist_field, fof.FloatField)
         dups_view.set_values(dist_field, dists)
 
     return dups_view

fiftyone/brain/internal/core/uniqueness.py

@@ -121,9 +121,7 @@ def compute_uniqueness(
     logger.info("Computing uniqueness...")
     uniqueness = _compute_uniqueness(embeddings)
 
-    samples._dataset._add_sample_field_if_necessary(
-        uniqueness_field, fof.FloatField
-    )
+    samples._dataset.add_sample_field(uniqueness_field, fof.FloatField)
     samples.set_values(uniqueness_field, uniqueness)
 
     brain_method.save_run_results(samples, brain_key, None)

setup.py

@@ -17,7 +17,7 @@
     long_description += "\n## License\n\n" + fh.read()
 
 
-VERSION = "0.8.3"
+VERSION = "0.9.0"
 
 
 def get_version():