Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade xmldom | Critical security issue detected by dependabot #370

Open
ghost opened this issue Sep 9, 2024 · 1 comment
Open

Upgrade xmldom | Critical security issue detected by dependabot #370

ghost opened this issue Sep 9, 2024 · 1 comment

Comments

@ghost
Copy link

ghost commented Sep 9, 2024

Impact
xmldom parses XML that is not well-formed because it contains multiple top level elements, and adds all root nodes to the childNodes collection of the Document, without reporting any error or throwing.
This breaks the assumption that there is only a single root node in the tree, which led to https://nvd.nist.gov/vuln/detail/CVE-2022-39299 and is a potential issue for dependents.

Patches
Update to @xmldom/xmldom@~0.7.7, @xmldom/xmldom@~0.8.4 (dist-tag latest) or @xmldom/xmldom@>=0.9.0-beta.4 (dist-tag next).

Workarounds
One of the following approaches might help, depending on your use case:

Instead of searching for elements in the whole DOM, only search in the documentElement.
Reject a document with a document that has more then 1 childNode.
References
https://nvd.nist.gov/vuln/detail/CVE-2022-39299
jindw/xmldom#150
For more information
If you have any questions or comments about this advisory:

Email us at [email protected]

@ghost
Copy link
Author

ghost commented Sep 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants