New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The code of creating host by kit and language-server is inconsistent #45

Open

johnsoncodehk opened this issue May 26, 2023 · 0 comments

Member

johnsoncodehk commented May 26, 2023

kit:

volar.js/packages/kit/src/createProject.ts

Line 50 in 67faf9c

const host: LanguageServiceHost = {

language server:

volar.js/packages/language-server/src/common/project.ts

Line 193 in 67faf9c

let host: embedded.LanguageServiceHost = {

We need to refactor the architecture to reuse code to avoid possible inconsistent behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment