Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor virtual code URI format #148

Closed
johnsoncodehk opened this issue Mar 1, 2024 · 0 comments
Closed

Refactor virtual code URI format #148

johnsoncodehk opened this issue Mar 1, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@johnsoncodehk
Copy link
Member

johnsoncodehk commented Mar 1, 2024 •
edited

Since 2.0, the format of the URI of virtual code's document has changed to:

{originalUri}?virtualCodeId={virtualCodeId}

Which seems to be semantically inaccurate. We can consider changing to the format used by VSCode's embedded language programming example:

volar-embedded-content://{encodeURIComponent(virtualCodeId)}/{encodeURIComponent(originalUri)}
@johnsoncodehk johnsoncodehk added the enhancement New feature or request label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johnsoncodehk