-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from 0.4.3 -> 0.5.5 leads to custom template breaking #1452
Comments
Hi @salwon, from Voila 0.5 there are some changes related to the static file location, is it possible to share your template? I can take a look at it |
I can't share the template unfortunately - is there anything I should look specifically for problems? My plan is to go through the |
Did you extend your template from the Lab template (https://github.com/voila-dashboards/voila/blob/main/share/jupyter/voila/templates/lab/index.html.j2) |
I misunderstood you I think - yes, the first line of ours is |
You can try to compare the source of a page rendered with your template and one with the default template, maybe there are some missing blocks. |
Do you mean on the older version? My page doesn't render with my template, the source doesn't show much. |
No, I mean the current Voila version. Could you post the diff? |
It's hard to judge from the above screenshot. I would be easier if you can make a minimal template to reproduce the bug |
Trying to run the vuetify-base template gives the same errors. |
|
Do you have a script tag with the id <script id="jupyter-config-data" type="application/json">
{
"appUrl": "voila/",
"appVersion": "0.5.5",
"baseUrl": "/",
"disabledExtensions": [],
"extensionConfig": {},
"federated_extensions": [
{
"extension": "./extension",
"load": "static/remoteEntry.5cbb9d2323598fbda535.js",
"name": "jupyterlab_pygments",
"style": "./style"
}
],
"fullLabextensionsUrl": "/voila/labextensions",
"fullMathjaxUrl": null,
"fullStaticUrl": "/voila/static",
"jupyterLabTheme": "light",
"kernelId": "d5201146-dbf8-4ebf-a8ae-7f371f914f0e",
"mathjaxConfig": null,
"terminalsAvailable": false,
"themesUrl": "/voila/api/themes"
}
</script> |
Yes - all that's in there is
|
That got it! I replaced the previous definition of that tag with |
Feel free to close the issue if it's fixed |
Description
I am currently attempting to update from 0.4.3 to 0.5.5 and running into an issue with our custom template which had worked previously. With 0.5.5, trying to load the notebook leads to a series of 404 errors:
Without referencing the template, the notebook loads successfully. The directory structure for the template looks like:
Does something need to change in the structure for the new version? I noticed the documentation is out of date (this ticket), what can I do to get my notebooks working with 0.5.5?
Reproduce
Have a working template in 0.4.3, upgrade Voila to 0.5.5.
Expected behavior
Notebook loads with correct template.
Context
The text was updated successfully, but these errors were encountered: