-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package gridstack's JS and CSS as part of the template #26
Comments
Hey guys, are there plans to depend on the npm package instead of baking a copy of static code into your release ? Alain (gridstack maintainer). |
Thanks Alain! Yes we plan to switch the way gridstack is packaged, and probably rely on a For reference, gridstack is currently used in 2 different places here:
voila-gridstack/share/jupyter/nbconvert/templates/gridstack/gridstack_base.html.j2 Line 4 in ac0c7de
|
At the moment we are still getting the gridstack CSS and JS from a CDN. It would probably be better to at least serve that content from the local static directory, before we move to the lab app approach.
The text was updated successfully, but these errors were encountered: