Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package gridstack's JS and CSS as part of the template #26

Open
SylvainCorlay opened this issue Nov 10, 2019 · 2 comments
Open

Package gridstack's JS and CSS as part of the template #26

SylvainCorlay opened this issue Nov 10, 2019 · 2 comments

Comments

@SylvainCorlay
Copy link
Member

At the moment we are still getting the gridstack CSS and JS from a CDN. It would probably be better to at least serve that content from the local static directory, before we move to the lab app approach.

@adumesny
Copy link

Hey guys, are there plans to depend on the npm package instead of baking a copy of static code into your release ?
I see you are on 2.0.0, which is great! but likely to be released with bug fixes as 2.x was quite a re-write... I would prefer to have download count toward my NPM package as well (show usage), but don't know how you create/distribute your package...

Alain (gridstack maintainer).

@jtpio
Copy link
Member

jtpio commented Sep 22, 2020

Thanks Alain!

Yes we plan to switch the way gridstack is packaged, and probably rely on a package.json with an additional build step.

For reference, gridstack is currently used in 2 different places here:

  • The template:

<link href="https://cdn.jsdelivr.net/npm/[email protected]/dist/gridstack.min.css" rel="stylesheet" />

jtpio pushed a commit to jtpio/voila-gridstack that referenced this issue Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants