Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCH Configure UI - add new UT #505

Open
javierfz1980 opened this issue May 31, 2018 · 0 comments
Open

VCH Configure UI - add new UT #505

javierfz1980 opened this issue May 31, 2018 · 0 comments
Assignees
Labels
component/plugin/h5c The plugin for the vSphere HTML5 client priority/p1 status/needs-estimation The issue needs to be estimated by the team team/lifecycle

Comments

@javierfz1980
Copy link
Contributor

javierfz1980 commented May 31, 2018

Since we are refactoring all the components of the VCH creation flow in order to use them as read-only, configure or create components we should add some UT in order to make sure that they are behaving as we expect on each flow.

Also we should test/validate that components are emitting internal model after any input form change in order to update the external cli component.

UT cases to be added to the new/refactored reconfigure components:

  • readonly state
  • configure state
  • create state
  • initial form values are equal to initialModel
  • updates the form values correctly
  • updates internal model after a form value change
  • updates the internal model only if form is valid
  • doesn't update the model if form is not valid
  • emits the model on any model change if is not readOnly
  • doesn't emits the model on model change if is not readOnly
  • commits the payload with correct content and model type

Also we are adding some brand new components that will also need UT in order to improve the coverage.

@javierfz1980 javierfz1980 added team/lifecycle component/plugin/h5c The plugin for the vSphere HTML5 client status/needs-estimation The issue needs to be estimated by the team labels May 31, 2018
@javierfz1980 javierfz1980 self-assigned this May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/plugin/h5c The plugin for the vSphere HTML5 client priority/p1 status/needs-estimation The issue needs to be estimated by the team team/lifecycle
Projects
None yet
Development

No branches or pull requests

2 participants