Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-210932 Improve UT runtime #1339

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

AV-210932 Improve UT runtime #1339

wants to merge 7 commits into from

Conversation

aaha97
Copy link
Contributor

@aaha97 aaha97 commented Dec 7, 2023

Run UTs in a single container, avoid running docker run with each make target

isolating test cases by using different names for resources created in test cases

@Dhivyaaj
Copy link

Dhivyaaj commented Dec 7, 2023

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@aaha97
Copy link
Contributor Author

aaha97 commented Dec 7, 2023

build ako

@akshayhavile
Copy link
Contributor

@aaha97 UT time seems to be improved by 20 min. Can we do one more experiment... can we check impact of increasing value of j to more than 1 in make -j 1 k8stest... command?

@Dhivyaaj
Copy link

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@aaha97
Copy link
Contributor Author

aaha97 commented Dec 13, 2023

build ako

@Dhivyaaj
Copy link

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@aaha97
Copy link
Contributor Author

aaha97 commented Dec 13, 2023

skip jira-id-check

@aaha97
Copy link
Contributor Author

aaha97 commented Dec 13, 2023

build ako

2 similar comments
@aaha97
Copy link
Contributor Author

aaha97 commented Dec 13, 2023

build ako

@akshayhavile
Copy link
Contributor

build ako

@Dhivyaaj
Copy link

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@aaha97
Copy link
Contributor Author

aaha97 commented Dec 14, 2023

build ako

1 similar comment
@aaha97
Copy link
Contributor Author

aaha97 commented Dec 14, 2023

build ako

@Dhivyaaj
Copy link

Dhivyaaj commented Jun 6, 2024

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

update UTs, seperate tests using different names for resources

skip TestMultiHostIngressStatusCheck due to status update concurrency issue.
addressed in another PR

separate gateway api tests

servicesapitests fixes, add clean cache command

avi-lb creation fix

rebasing PR
@aaha97
Copy link
Contributor Author

aaha97 commented Sep 20, 2024

build ako

3 similar comments
@aaha97
Copy link
Contributor Author

aaha97 commented Sep 24, 2024

build ako

@aaha97
Copy link
Contributor Author

aaha97 commented Sep 24, 2024

build ako

@aaha97
Copy link
Contributor Author

aaha97 commented Sep 25, 2024

build ako

@aaha97
Copy link
Contributor Author

aaha97 commented Sep 25, 2024

build ako

@aaha97
Copy link
Contributor Author

aaha97 commented Sep 25, 2024

build ako

@aaha97
Copy link
Contributor Author

aaha97 commented Sep 25, 2024

build ako

1 similar comment
@aaha97
Copy link
Contributor Author

aaha97 commented Sep 25, 2024

build ako

@@ -2125,6 +2125,10 @@ func SetupIngressClass(t *testing.T, ingclassName, controller, infraSetting stri
t.Fatalf("error in adding IngressClass: %v", err)
}
}
if len(wait) > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated


.PHONY: int_test
int_test:
make -j 1 k8stest integrationtest ingresstests evhtests vippernstests dedicatedevhtests dedicatedvippernstests oshiftroutetests bootuptests multicloudtests advl4tests namespacesynctests servicesapitests npltests misc dedicatedvstests hatests calicotests ciliumtests helmtests infratests urltests gatewayapitests
make -j 8 bootuptests ciliumtests k8stest multicloudtests \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would need more clarification on how are we going to identify the error in case of failure.

@aaha97
Copy link
Contributor Author

aaha97 commented Sep 26, 2024

build ako

1 similar comment
@aaha97
Copy link
Contributor Author

aaha97 commented Sep 26, 2024

build ako

@aaha97
Copy link
Contributor Author

aaha97 commented Sep 26, 2024

build ako

2 similar comments
@aaha97
Copy link
Contributor Author

aaha97 commented Sep 26, 2024

build ako

@aaha97
Copy link
Contributor Author

aaha97 commented Sep 26, 2024

build ako

@aaha97
Copy link
Contributor Author

aaha97 commented Sep 26, 2024

build ako

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants