Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable a way to trigger downstream build and test jobs based on a PR #8

Open
dramdass opened this issue Mar 31, 2021 · 1 comment
Open

Comments

@dramdass
Copy link
Contributor

This may involve a maintainer running an internal Jenkins job with a PR ref or commit SHA on a topic branch.

@janitha
Copy link
Contributor

janitha commented Apr 6, 2021

The most ideal solution would be to expose VMware internal CI/CD system webhooks to github, but that's going to be a hurdle with IT/Security.

While not instantaneous, another option is for VMware internal CI/CD to poll this project periodically/frequently for pending PRs, and do the necessary builds/tests, and then post back status on the PR.

Also, seems like we should have some gating mechanism before build/test are triggered within the VMware CI/CD (this was a point raised by the security folks), since the PR's change may contain malicious code that would run as part of the build/test jobs. One idea would to be introduce some sort of tag/label that can be set on the PR by a maintainer/reviewer.

akutz pushed a commit that referenced this issue Nov 19, 2022
* Update controller-runtime to 0.5.1

* Remove controller-runtime dependency in the API - only used for samples

* Update dependencies post-merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@janitha @dramdass and others