Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4RFC: Workload spec update for maven artifacts #741

Closed
jwntrs opened this issue Mar 23, 2022 · 5 comments · May be fixed by #767
Closed

R4RFC: Workload spec update for maven artifacts #741

jwntrs opened this issue Mar 23, 2022 · 5 comments · May be fixed by #767
Assignees
@emmjohnson
Labels
r4rfc
Milestone
0.4.0

Comments

@jwntrs
Copy link
Contributor

jwntrs commented Mar 23, 2022

Description of problem

Currently the workload spec has fields for source.git and source.image, neither of which is suitable for basing a workload off a maven artifact. We are requesting an RFC that proposes an update to the workload spec to address this use case.

Open question

What about S3 artifacts (fluxcd Bucket resource)? Would we treat these the same as maven artifacts?
@jwntrs jwntrs added the r4rfc label Mar 23, 2022
@jwntrs jwntrs added this to the 0.4.0 milestone Mar 24, 2022
@scothis
Copy link
Contributor

scothis commented Mar 28, 2022

@jwntrs can you add "Maven" to the subject to clarify this isn't related to artifact tracing

@jwntrs jwntrs changed the title R4RFC: Workload spec update for artifacts R4RFC: Workload spec update for maven artifacts Mar 28, 2022
@cirocosta
Copy link
Contributor

related: https://github.com/nulldriver/maven-resource (concourse)

resource_types:
- name: maven-resource
  type: registry-image
  source:
    repository: nulldriver/maven-resource
    tag: latest

resources:
- name: artifact
  type: maven-resource
  source:
    url: https://myrepo.example.com/repository/maven-releases/
    snapshot_url: https://myrepo.example.com/repository/maven-snapshots/
    artifact: com.example:example-webapp:jar
    username: myuser
    password: mypass
    repository_cert: |
      -----BEGIN CERTIFICATE-----
      MIIEowIBAAKCAQEAtCS10/f7W7lkQaSgD/mVeaSOvSF9ql4hf/zfMwfVGgHWjj+W
      <Lots more text>
      DWiJL+OFeg9kawcUL6hQ8JeXPhlImG6RTUffma9+iGQyyBMCGd1l
      -----END CERTIFICATE-----

@emmjohnson emmjohnson self-assigned this Mar 30, 2022
@emmjohnson emmjohnson linked a pull request Mar 30, 2022 that will close this issue
RFC for Maven and Artifactory support #767
Draft
@heyjcollins
Copy link

cc @rashedkvm @atmandhol

@cirocosta cirocosta moved this from PR to Doing in Cartographer OSS Apr 14, 2022
@squeedee squeedee moved this from Doing to Pre-IPM in Cartographer OSS Aug 29, 2022
@squeedee
Copy link
Member

@cirocosta do you know what the upstream plans are for specifying Maven

@karayim
Copy link

karayim commented Oct 7, 2022

Implemented using params

@karayim karayim closed this as completed Oct 7, 2022
Repository owner moved this from Pre-IPM to Closed in Cartographer OSS Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emmjohnson emmjohnson

Labels
r4rfc
Projects
Cartographer OSS
Status: Closed
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

RFC for Maven and Artifactory support vmware-tanzu/cartographer
7 participants
@squeedee @scothis @jwntrs @cirocosta @karayim @heyjcollins @emmjohnson