Remove Split A/B testing framework

We were running an experiment to test the text of the GitHub auth button. The results were very similar and we chose to stick with "Sign In with GitHub." Relevant discussion: https://thoughtbot.slack.com/archives/C02AJF2A0/p1496253165859654
vladgogo · May 31, 2017 · 35f551c · 35f551c
1 parent ac55bf9
commit 35f551c
Show file tree

Hide file tree

Showing 12 changed files with 5 additions and 54 deletions.
diff --git a/.env b/.env
@@ -18,6 +18,5 @@ RESQUE_ADMIN_PASSWORD=password
 RESQUE_JOB_TIMEOUT=120
 SECRET_KEY_BASE=some_really_really_long_super_secret_key_base
 SEGMENT_KEY=segment_key
-SPLIT_ADMIN_PASSWORD=split_password
 STRIPE_API_KEY=sk_test_123
 STRIPE_PUBLISHABLE_KEY=pk_test_123
diff --git a/Gemfile b/Gemfile
@@ -35,7 +35,6 @@ gem "resque-sentry"
 gem "rest-client", ">= 1.8.0"
 gem "sass-rails"
 gem "sinatra", "2.0.0.beta2"
-gem "split", require: "split/dashboard"
 gem "stripe"
 gem "thor", "0.19.1"
 gem "uglifier", ">= 2.7.2"

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -307,16 +307,11 @@ GEM
       faraday (>= 0.7.6, < 1.0)
     shoulda-matchers (2.6.2)
       activesupport (>= 3.0.0)
-    simple-random (1.0.3)
     sinatra (2.0.0.beta2)
       mustermann (= 1.0.0.beta2)
       rack (~> 2.0)
       rack-protection (= 2.0.0.beta2)
       tilt (~> 2.0)
-    split (2.2.0)
-      redis (>= 2.1)
-      simple-random (>= 0.9.3)
-      sinatra (>= 1.2.6)
     sprockets (3.7.1)
       concurrent-ruby (~> 1.0)
       rack (> 1, < 3)
@@ -400,7 +395,6 @@ DEPENDENCIES
   sentry-raven (>= 0.12.2)
   shoulda-matchers
   sinatra (= 2.0.0.beta2)
-  split
   stripe
   thor (= 0.19.1)
   uglifier (>= 2.7.2)

diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb
@@ -9,7 +9,6 @@ def create
       update_scopes
     end
 
-    ab_finished("auth_button")
     redirect_to repos_path
   end
 

diff --git a/app/views/application/_analytics.haml b/app/views/application/_analytics.haml
@@ -20,8 +20,7 @@
     for (var i = 0; i < links.length; i++) {
       window.analytics.trackLink(
         links[i],
-        "Clicked Sign In",
-        { variation: "#{ab_test("auth_button")}" }
+        "Clicked Sign In"
       );
     }
 

diff --git a/app/views/application/_auth_button.haml b/app/views/application/_auth_button.haml
@@ -1,3 +1,3 @@
 = link_to "/auth/github", class: "auth" do
   %i.fa.fa-github
-  %span= ab_test("auth_button")
+  = t("authenticate")
diff --git a/config/experiments.yml b/config/experiments.yml
diff --git a/config/initializers/split.rb b/config/initializers/split.rb
diff --git a/config/routes.rb b/config/routes.rb
@@ -10,7 +10,6 @@
 
   mount Resque::Server, at: "/queue"
   mount JasmineRails::Engine => "/specs" if defined?(JasmineRails)
-  mount Split::Dashboard, at: "split"
 
   get "/auth/github/callback", to: "sessions#create"
   get "/sign_out", to: "sessions#destroy"

diff --git a/spec/features/public_pages_spec.rb b/spec/features/public_pages_spec.rb
@@ -3,14 +3,14 @@
 feature "Public Pages" do
   context "When a user is not signed in" do
     scenario "displays the configuration page" do
-      visit "/configuration?SPLIT_DISABLE=true"
+      visit "/configuration"
 
       expect(page).to have_content("Configuration")
       expect(page).to have_content("Sign In with GitHub")
     end
 
     scenario "displays the configuration page with params and missing ?" do
-      visit "/configuration&utm_source=Intercom&SPLIT_DISABLE=true"
+      visit "/configuration&utm_source=Intercom"
 
       expect(page).to have_content("Configuration")
       expect(page).to have_content("Sign In with GitHub")

diff --git a/spec/requests/split_route_spec.rb b/spec/requests/split_route_spec.rb
diff --git a/spec/support/helpers/authentication_helper.rb b/spec/support/helpers/authentication_helper.rb
@@ -6,7 +6,7 @@ def stub_sign_in(user)
 
   def sign_in_as(user, token = "letmein")
     stub_oauth(username: user.username, email: user.email, token: token)
-    visit root_path(SPLIT_DISABLE: "true")
+    visit root_path
     click_link(I18n.t('authenticate'), match: :first)
   end
 end
-Original file line number
+Diff line change
@@ Expand Up / @@ -9,7 +9,6 @@ def create @@
           update_scopes
         end
-        ab_finished("auth_button")
         redirect_to repos_path
       end
@@ Expand Down @@