Move pricing logic into plan model

Old `Plan` model become obsolete with tiered plans.
`Pricing` was an odd-name because `Plan` was taken.
We can now move new logic into the `Plan` model, and refactor
surrounding tier logic.

app/assets/javascripts/components/__tests__/__snapshots__/notify_tier_change-test.jsx.snap

@@ -43,7 +43,7 @@ exports[`NotifyTierChange snapshots renders plans appropriately (Chihuahua -> La
   <div
     className="tier-change-content">
     <h1>
-      Pricing: Change of Plans
+      Change of Plans
     </h1>
     <section
       className="tier-change-description">
@@ -133,7 +133,7 @@ exports[`NotifyTierChange snapshots renders plans appropriately (Labrador -> Gre
   <div
     className="tier-change-content">
     <h1>
-      Pricing: Change of Plans
+      Change of Plans
     </h1>
     <section
       className="tier-change-description">

app/assets/javascripts/components/notify_tier_change.jsx

@@ -77,7 +77,7 @@ class NotifyTierChange extends React.Component {
           {this.renderTierPlans()}
         </aside>
         <div className="tier-change-content">
-          <h1>Pricing: Change of Plans</h1>
+          <h1>Change of Plans</h1>
           <section className="tier-change-description">
             <div className="allowance large">
               Private Repos

app/assets/javascripts/components/repos_container.jsx

@@ -92,7 +92,7 @@ class ReposContainer extends React.Component {
   updateSubscribedRepoCount() {
     this.getUser().then(user => {
       const subscribedRepoCount = user.subscribed_repo_count;
-      const tierAllowance = user.tier_allowance;
+      const tierAllowance = user.plan_max;
 
       if (subscribedRepoCount === 0) {
         $("[data-role='allowance-container']").remove();
@@ -123,7 +123,7 @@ class ReposContainer extends React.Component {
 
   onSubscriptionError(repo, error) {
     if (error.status === 402) {
-      document.location.href = `/pricings?repo_id=${repo.id}`;
+      document.location.href = `/plans?repo_id=${repo.id}`;
     } else {
       alert("Your subscription could not be activated.");
     }

app/controllers/plans_controller.rb

@@ -0,0 +1,16 @@
+class PlansController < ApplicationController
+  def index
+    @plans = ActiveModel::ArraySerializer.new(
+      Plan.all,
+      each_serializer: PlanSerializer,
+      scope: current_user,
+    )
+    @repo = Repo.find(plan_params[:repo_id])
+  end
+
+  private
+
+  def plan_params
+    params.permit(:repo_id)
+  end
+end

app/controllers/subscriptions_controller.rb

@@ -5,7 +5,7 @@ class FailedToActivate < StandardError; end
   before_action :update_email
 
   def create
-    if Tier.new(current_user).full?
+    if current_user.plan_upgrade?
       render json: {}, status: :payment_required
     elsif activator.activate && create_subscription
       render json: repo, status: :created

app/models/analytics.rb

@@ -26,7 +26,7 @@ def track_repo_deactivated(repo)
       properties: {
         name: repo.name,
         private: repo.private,
-        revenue: -repo.plan_price,
+        revenue: lost_revenue,
       }
     )
   end
@@ -53,12 +53,20 @@ def track_build_completed(repo)
 
   private
 
+  attr_reader :user
+
   def track(options)
     backend.track({
       active_repos_count: user.repos.active.count,
       user_id: user.id,
     }.merge(options))
   end
 
-  attr_reader :user
+  def lost_revenue
+    if user.current_plan == user.next_plan
+      0
+    else
+      user.current_plan_price - user.next_plan_price
+    end
+  end
 end

app/models/home.rb

@@ -5,29 +5,29 @@ def initialize(user)
     @user = user
   end
 
-  def open_source_pricings
-    open_source_repos.map { |pricing| present(pricing) }
+  def open_source_plans
+    open_source_repos.map { |plan| present(plan) }
   end
 
-  def private_pricings
-    private_repos.map { |pricing| present(pricing) }
+  def private_plans
+    private_repos.map { |plan| present(plan) }
   end
 
   private
 
-  def present(pricing)
-    PricingPresenter.new(pricing: pricing, user: user)
+  def present(plan)
+    PlanPresenter.new(plan: plan, user: user)
   end
 
-  def pricings
-    Pricing.all
+  def plans
+    Plan.all
   end
 
   def private_repos
-    pricings.reject(&:open_source?)
+    plans.reject(&:open_source?)
   end
 
   def open_source_repos
-    pricings.select(&:open_source?)
+    plans.select(&:open_source?)
   end
 end

app/models/payment_gateway_customer.rb

@@ -32,7 +32,7 @@ def subscription
   def retrieve_subscription(subscription_id)
     PaymentGatewaySubscription.new(
       stripe_subscription: customer.subscriptions.retrieve(subscription_id),
-      tier: tier,
+      user: user,
     )
   end
 
@@ -54,7 +54,7 @@ def update_email(email)
   def create_subscription(options)
     PaymentGatewaySubscription.new(
       stripe_subscription: customer.subscriptions.create(options),
-      tier: tier,
+      user: user,
     )
   end
 
@@ -67,15 +67,11 @@ def subscriptions
     customer.subscriptions.map do |subscription|
       PaymentGatewaySubscription.new(
         stripe_subscription: subscription,
-        tier: tier,
+        user: user,
       )
     end
   end
 
-  def tier
-    Tier.new(user)
-  end
-
   class NoRecord
     def email
       ""

app/models/payment_gateway_subscription.rb

@@ -1,5 +1,5 @@
 class PaymentGatewaySubscription
-  attr_reader :stripe_subscription, :tier
+  attr_reader :stripe_subscription, :user
 
   delegate(
     :id,
@@ -11,14 +11,14 @@ class PaymentGatewaySubscription
     to: :stripe_subscription,
   )
 
-  def initialize(stripe_subscription:, tier:)
+  def initialize(stripe_subscription:, user:)
     @stripe_subscription = stripe_subscription
-    @tier = tier
+    @user = user
   end
 
   def subscribe(repo_id)
     append_repo_id_to_metadata(repo_id)
-    self.plan = tier.next.id
+    self.plan = user.next_plan.id
     save
   end
 
@@ -51,11 +51,7 @@ def current_repo_ids
   end
 
   def downgraded_plan
-    previous_tier.id
-  end
-
-  def previous_tier
-    tier.previous
+    user.previous_plan.id
   end
 
   def stripe_plan

app/models/plan.rb

@@ -1,37 +1,44 @@
 class Plan
-  PRICES = {
-    bulk: 0,
-    public: 0,
-    private: 12
-  }
-
-  TYPES = {
-    bulk: "bulk",
-    public: "public",
-    private: "private"
-  }
-
-  def initialize(repo)
-    @repo = repo
+  include ActiveModel::Serialization
+
+  PLANS = [
+    { id: "basic", price: 0, range: 0..0, title: "Hound" },
+    { id: "tier1", price: 49, range: 1..4, title: "Chihuahua" },
+    { id: "tier2", price: 99, range: 5..10, title: "Labrador" },
+    { id: "tier3", price: 249, range: 11..30, title: "Great Dane" },
+  ].freeze
+
+  attr_reader :id, :price, :title
+
+  def initialize(id:, range:, price:, title:)
+    @id = id
+    @range = range
+    @price = price
+    @title = title
   end
 
-  def type
-    if @repo.bulk?
-      TYPES[:bulk]
-    elsif @repo.private?
-      TYPES[:private]
-    else
-      TYPES[:public]
-    end
+  def self.all
+    PLANS.map { |plan| new(plan) }
   end
 
-  def price
-    if @repo.bulk?
-      PRICES[:bulk]
-    elsif @repo.private?
-      PRICES[:private]
-    else
-      PRICES[:public]
-    end
+  def self.find_by(count:)
+    found = PLANS.detect { |plan| plan.fetch(:range).include?(count) }
+    new(found)
   end
+
+  def ==(other)
+    id == other.id
+  end
+
+  def allowance
+    range.max
+  end
+
+  def open_source?
+    price.zero?
+  end
+
+  private
+
+  attr_reader :range
 end

app/models/plan_selector.rb

@@ -0,0 +1,39 @@
+class PlanSelector
+  BULK_ID = "bulk".freeze
+
+  def initialize(user)
+    @user = user
+  end
+
+  def current_plan
+    find_plan(repo_count)
+  end
+
+  def next_plan
+    find_plan(repo_count.succ)
+  end
+
+  def previous_plan
+    find_plan(repo_count.pred)
+  end
+
+  def upgrade?
+    current_plan != next_plan
+  end
+
+  private
+
+  attr_reader :user
+
+  def repo_count
+    @_repo_count ||= repos.size
+  end
+
+  def find_plan(count)
+    Plan.find_by(count: count)
+  end
+
+  def repos
+    user.subscribed_repos
+  end
+end