forked from houndci/hound
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Remove sticky header; it caused shifting in the nav's height which can be distracting. - Wrap the navigation in a `nav` element (rather than `header`) which is more semantically correct and maps to the `navigation` role in the accessibility tree. - Component-ize CSS: `avatar`, `logo` and `icon` are now reusable components. - Begin using SVG `symbol` for icon and SVG assets, instead of Font Awesome or using the SVG through an `img` tag. This allows for CSS styles (e.g. `fill` color) and _greatly_ improves accessibility. - Remove Twitter link (it is still listed in the footer). - Maintain Pricing and Sign In with GitHub links across all breakpoints instead of removing them on mobile. - Vastly simplify CSS, including removal of over-qualified selectors (e.g. `ul li a.auth`). - Remove the need for page-based classes via `content_for :header_class`.
- Loading branch information
Showing
24 changed files
with
185 additions
and
263 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,5 +7,3 @@ | |
|
||
//= require react_ujs | ||
//= require classnames | ||
|
||
//= require sticky-header |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,3 +6,4 @@ | |
@import "base/base"; | ||
@import "components/components"; | ||
@import "pages/pages"; | ||
@import "utilities/utilities"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,10 +19,6 @@ | |
|
||
.content { | ||
@include outer-container; | ||
|
||
&.repo-index { | ||
padding-top: 10em; | ||
} | ||
} | ||
|
||
.inner-wrapper { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
$_app-nav-layout-breakpoint: 42em; | ||
|
||
.app-nav { | ||
font-weight: $font-weight-normal; | ||
|
||
a { | ||
color: $base-font-color; | ||
|
||
&:hover { | ||
color: $base-accent-color; | ||
} | ||
} | ||
} | ||
|
||
.app-nav__container { | ||
align-items: center; | ||
display: flex; | ||
flex-direction: column; | ||
padding: 2rem; | ||
|
||
@media (min-width: $_app-nav-layout-breakpoint) { | ||
flex-direction: row; | ||
} | ||
} | ||
|
||
.app-nav__logo { | ||
display: block; | ||
|
||
@media (max-width: $_app-nav-layout-breakpoint) { | ||
margin-bottom: $base-spacing; | ||
} | ||
|
||
@media (min-width: $_app-nav-layout-breakpoint) { | ||
margin-right: $base-spacing; | ||
} | ||
} | ||
|
||
.app-nav__item:not(:first-of-type) { | ||
margin-left: $base-spacing; | ||
} | ||
|
||
.app-nav__app-items { | ||
@media (max-width: $_app-nav-layout-breakpoint) { | ||
margin-bottom: $base-spacing; | ||
} | ||
} | ||
|
||
.app-nav__user-items { | ||
align-items: center; | ||
display: flex; | ||
|
||
@media (min-width: $_app-nav-layout-breakpoint) { | ||
margin-left: auto; | ||
} | ||
} | ||
|
||
.app-nav__account-link { | ||
align-items: center; | ||
display: flex; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
$_avatar-size: 2rem; | ||
|
||
.avatar { | ||
@include size($_avatar-size); | ||
background-color: $light-gray; | ||
border-radius: 50%; | ||
display: inline-block; | ||
overflow: hidden; | ||
position: relative; | ||
vertical-align: middle; | ||
|
||
&::after { | ||
@include position(absolute, 0); | ||
border-radius: 50%; | ||
box-shadow: inset 0 0 0 1px rgba($black, 0.1); | ||
content: ""; | ||
pointer-events: none; | ||
} | ||
|
||
img { | ||
@include size($_avatar-size); | ||
object-fit: cover; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,12 @@ | ||
@import "allowance"; | ||
@import "app-nav"; | ||
@import "avatar"; | ||
@import "button"; | ||
@import "code"; | ||
@import "footer"; | ||
@import "header"; | ||
@import "icon"; | ||
@import "inline-flash"; | ||
@import "logo"; | ||
@import "plan-markers"; | ||
@import "pricing"; | ||
@import "toggle_switch"; |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
.icon { | ||
@include size(1em); | ||
fill: currentcolor; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
$_logo-aspect-ratio: 217 / 50; | ||
$_logo-height: 2.5rem; | ||
$_logo-color: $purple; | ||
|
||
.logo { | ||
fill: $_logo-color; | ||
height: $_logo-height; | ||
transition: fill $base-transition-timing $base-easing; | ||
width: $_logo-height * $_logo-aspect-ratio; | ||
|
||
&:hover { | ||
fill: shade($_logo-color, 15%); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.line-height-zero { | ||
line-height: 0; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.margin-right-x-small { | ||
margin-right: $xsmall-spacing; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
@import "line-height"; | ||
@import "margin"; |
Oops, something went wrong.