Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section "audiobooks and shows" not shown #12

Open
gregthwuen opened this issue May 18, 2024 · 4 comments
Open

Section "audiobooks and shows" not shown #12

gregthwuen opened this issue May 18, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@gregthwuen
Copy link

gregthwuen commented May 18, 2024

The section "audiobooks and shows" is not shown on an artist's profiles. The albums in question can still be found and played back by searching for them.

As an example, here's one of the affected artists: https://music.youtube.com/channel/UCkBOK5_V5AcQlye0TV2g0-A (you might not see all the items since most of them are premium-only)

Screenshot from 2024-05-18 02-23-40
Screenshot from 2024-05-18 02-21-35

@vixalien
Copy link
Owner

Yes. Audiobooks and podcasts are not explicitly supported by Muzika (and https://github.com/vixalien/muse). I don't know if the support is worth it to be honest. They will possibly be supported later.

@vixalien vixalien added the enhancement New feature or request label May 18, 2024
@gregthwuen
Copy link
Author

The way I understand it, a "Show" is just another album_type. Wouldn't adding this category simply consist of copying the logic of the existing categories?

I totally understand if that's not your priority, but if it's really this straight-forward I'd be willing to give it a try.

@vixalien
Copy link
Owner

The way I understand it, a "Show" is just another album_type.

Ah, I see. It's still going to get a bit complicated though. Here's a rough guide to get you started. You'll run into a few issues as the muse stuff isbt that documented yet, but you can give it a go.

First, you gotta download and prepare https://github.com/vixalien/muse by cloning it and then installing deno.land.

Then you're gonna log in by running the file.

deno run -A client.ts

Then you're going to want to add the audio books and shows section here

["related", "Fans might also like"],
so we can automatically get different translations and be able to correctly get that info.

Then add the channel for the artist above here

Then you can run the locales/strings.ts script and make sure it runs completely without errors.

After that the locales/strings.json file will get updated. Check to see if the correct translations have been added in.

After that it's time to make sure that information shows up in channel pages (I'm assuming it's a channel, not an artist page). Add a line here

playlists: [_("playlists"), parse_playlist],
to get the audio books and shows.

To test all this, update the code in the client.ts file to call get_channel with the specified channel ID above. If all goes well, you should be able to see the information.

After that, the libmuse part will be done and we will need to update Muzika.

Sorryy this stuff is not really documented but I'm working on improving it and ask questions when you get confused.

@vixalien vixalien transferred this issue from vixalien/muzika May 18, 2024
@gregthwuen
Copy link
Author

Thanks for the intro! I already played around with the library earlier, I'll definitely give it a try and let you know if it worked out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants