-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
branch develop: user profile images are not in 1:1 aspect ratio #167
Comments
Not everybody has portrait pictures; I guess there are a lot of selfies and those are not squared. But you're right, the functionality to upload additional pictures would be useful. |
gusbakker
pushed a commit
to gusbakker/bootcamp
that referenced
this issue
Apr 13, 2020
- Added password change functionality. - vitorfs#167 Restored the old crop profile image section and fixed profile images aspect ratio. - Changed Notifications and News UI to a better looking. - Added Bell notification with number count. - Changed delete news posts to be removed by Ajax request. - Updated migrations so ImageField is not anymore in User model (since upload mage has changed) - vitorfs#222 Added links in Notifications and fixed 'replied to' messages (still have to put the right addres to the links)
This was referenced Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Picture.js in master branch was handling that. But I understand, using sorl.thumbnail doesnot require cropping. But recangular images appear in oval shape in the new feed page which looks does not look as good as circular images of master branch.
In the templates the common syntax is:
{% thumbnail reply.user.picture "x60" as im %}
instead, We should use
{% thumbnail reply.user.picture "60x60" as im %}
or
{% thumbnail reply.user.picture "60x60" crop="center" as im %}
On top of this we should allow users to pick the center of the image. Which may require picture.js
The text was updated successfully, but these errors were encountered: