Skip to content

Commit 3f4fa20

Browse files
committed
Fixed release notes and typo in make-release.sh
1 parent 4add023 commit 3f4fa20

File tree

3 files changed

+52
-51
lines changed

3 files changed

+52
-51
lines changed

doc/source/install.rst

+15-16
Original file line numberDiff line numberDiff line change
@@ -34,34 +34,33 @@ RPM installation
3434

3535
2. Setup the decision engine yum repositories ::
3636

37-
wget -O /etc/yum.repos.d/ssi-hepcloud.repo http://ssi-rpm.fnal.gov/hep/ssi-hepcloud.repo
38-
wget -O /etc/yum.repos.d/ssi-hepcloud-dev.repo http://ssi-rpm.fnal.gov/hep/ssi-hepcloud-dev.repo
39-
# Note the above repos are only accessible within Fermilab. There is an alternative place on github to get the RPMs if you are off-site.
37+
wget -O /etc/yum.repos.d/ssi-hepcloud.repo http://ssi-rpm.fnal.gov/hep/ssi-hepcloud.repo
38+
wget -O /etc/yum.repos.d/ssi-hepcloud-dev.repo http://ssi-rpm.fnal.gov/hep/ssi-hepcloud-dev.repo
39+
# Note the above repos are only accessible within Fermilab. There is an alternative place on github to get the RPMs if you are off-site.
4040

4141
3. Install the decision engine (add `--enablerepo=ssi-hepcloud-dev` for the latest development version) ::
4242

43-
DE_REPO=ssi-hepcloud-dev
44-
dnf install -y --enablerepo="$DE_REPO" decisionengine-onenode
45-
# Individual packages are: decisionengine-deps (framework req) decisionengine-modules-deps (modules req) decisionengine-standalone (2 deps+httpd)
43+
DE_REPO=ssi-hepcloud-dev
44+
dnf install -y --enablerepo="$DE_REPO" decisionengine-onenode
45+
# Individual packages are: decisionengine-deps (framework req) decisionengine-modules-deps (modules req) decisionengine-standalone (2 deps+httpd)
4646

4747
4. Install the required Python packages (these are taken from setup.py) ::
4848

49-
decisionengine-install-python
50-
# This shell script (included in decisionengine-deps) installs the Decision Engine Python code.
51-
# You can run it as root or as the decisionengine user
52-
# To see all the options: decisionengine-install-python --help
53-
54-
# Double check that pip added $HOME/.local/bin to the PATH of user decisionengine
49+
decisionengine-install-python --de-git-ref 2.0.4
50+
# This shell script (included in decisionengine-deps) installs the Decision Engine Python code.
51+
# You can run it as root or as the decisionengine user
52+
# To see all the options: decisionengine-install-python --help
53+
# Double check that pip added $HOME/.local/bin to the PATH of user decisionengine
5554

5655
5. Start and enable HTCondor::
5756

58-
systemctl start condor
59-
systemctl enable condor
57+
systemctl start condor
58+
systemctl enable condor
6059

6160
6. Optionally install these extra packages ::
6261

63-
# htgettoken - if you need it to generate SciTokens
64-
dnf -y install htgettoken
62+
# htgettoken - if you need it to generate SciTokens
63+
dnf -y install htgettoken
6564

6665

6766
Fix the GlideinWMS Frontend installation

doc/source/release_notes/release_notes_2.0.rst

+35-33
Original file line numberDiff line numberDiff line change
@@ -10,40 +10,42 @@ There are also new Prometheus metrics and a few bug fixes like the source loggin
1010
Issues fixed in this release
1111
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1212

13-
Bugs fixed
14-
-`DE 670 <https://github.com/HEPCloud/decisionengine/pull/670>`_: changes to fix source logging (@goodenou)
15-
-`DE 674 <https://github.com/HEPCloud/decisionengine/pull/674>`_: Upgrading isort version to fix pre-config install error w/ poetry (@mambelli)
16-
-`DE 683 <https://github.com/HEPCloud/decisionengine/pull/683>`_: Fix unit tests (@vitodb)
17-
-`DE 696 <https://github.com/HEPCloud/decisionengine/pull/696>`_: Re-enable flake8 linter (@vitodb)
18-
-`DE 701 <https://github.com/HEPCloud/decisionengine/pull/701>`_: Fixed bugs in metrics with labels (@IlyaBaburashvili)
19-
-`DE 700 <https://github.com/HEPCloud/decisionengine/pull/700>`_: For flake8 skip build folder (@vitodb)
20-
-`DE 713 <https://github.com/HEPCloud/decisionengine/pull/713>`_: Set /metrics Content-type header to text/plain (@shreyb)
21-
-`DE 710 <https://github.com/HEPCloud/decisionengine/pull/710>`_: add invocation in the child processes for sources/channels logging (@namrathaurs)
13+
Bugs fixed:
14+
15+
- `DE 670 <https://github.com/HEPCloud/decisionengine/pull/670>`_: changes to fix source logging (@goodenou)
16+
- `DE 674 <https://github.com/HEPCloud/decisionengine/pull/674>`_: Upgrading isort version to fix pre-config install error w/ poetry (@mambelli)
17+
- `DE 683 <https://github.com/HEPCloud/decisionengine/pull/683>`_: Fix unit tests (@vitodb)
18+
- `DE 696 <https://github.com/HEPCloud/decisionengine/pull/696>`_: Re-enable flake8 linter (@vitodb)
19+
- `DE 701 <https://github.com/HEPCloud/decisionengine/pull/701>`_: Fixed bugs in metrics with labels (@IlyaBaburashvili)
20+
- `DE 700 <https://github.com/HEPCloud/decisionengine/pull/700>`_: For flake8 skip build folder (@vitodb)
21+
- `DE 713 <https://github.com/HEPCloud/decisionengine/pull/713>`_: Set /metrics Content-type header to text/plain (@shreyb)
22+
- `DE 710 <https://github.com/HEPCloud/decisionengine/pull/710>`_: add invocation in the child processes for sources/channels logging (@namrathaurs)
2223

2324
Enhancements:
24-
-`DE 668 <https://github.com/HEPCloud/decisionengine/pull/668>`_: Introduce publisher status data product (@knoepfel)
25-
-`DE 671 <https://github.com/HEPCloud/decisionengine/pull/671>`_: explicitly select a container with all our required python versions (@jcpunk)
26-
-`DE 676 <https://github.com/HEPCloud/decisionengine/pull/676>`_: Added EL9 instructions (@mambelli)
27-
-`DE 678 <https://github.com/HEPCloud/decisionengine/pull/678>`_: Updated and tested instructions, PIP installation working (@mambelli)
28-
-`DE 679 <https://github.com/HEPCloud/decisionengine/pull/679>`_: Disabling unit tests for python 3.6 (@vitodb)
29-
-`DE 680 <https://github.com/HEPCloud/decisionengine/pull/680>`_: Make default database init use stronger data protections (@jcpunk)
30-
-`DE 681 <https://github.com/HEPCloud/decisionengine/pull/681>`_: Update to pytest 7 with pytest-postgresql 5 (@jcpunk)
31-
-`DE 682 <https://github.com/HEPCloud/decisionengine/pull/682>`_: Updated EL9 instruction: PIP installation and GWMS config tested (@mambelli)
32-
-`DE 685 <https://github.com/HEPCloud/decisionengine/pull/685>`_: Enable some tests only on DE 1.7 branch (@vitodb)
33-
-`DE 687 <https://github.com/HEPCloud/decisionengine/pull/687>`_: Update GH actions (@vitodb)
34-
-`DE 688 <https://github.com/HEPCloud/decisionengine/pull/688>`_: Added two metrics on the Source - de_source_status and de_source_acquire_seconds (@skylerfoster67)
35-
-`DE 690 <https://github.com/HEPCloud/decisionengine/pull/690>`_: Adding DE EL9 containers based on AlmaLinux9 (@vitodb)
36-
-`DE 691 <https://github.com/HEPCloud/decisionengine/pull/691>`_: Adding Jenkinsfile for EL9 (@vitodb)
37-
-`DE 689 <https://github.com/HEPCloud/decisionengine/pull/689>`_: Added new de-client metrics for duration (@IlyaBaburashvili)
38-
-`DE 694 <https://github.com/HEPCloud/decisionengine/pull/694>`_: Decision Engine Components Data (@skylerfoster67)
39-
-`DE 697 <https://github.com/HEPCloud/decisionengine/pull/697>`_: Redis Exporter Data (@skylerfoster67)
40-
-`DE 703 <https://github.com/HEPCloud/decisionengine/pull/703>`_: Create Redis mock for unit tests (@shreyb)
41-
-`DE 706 <https://github.com/HEPCloud/decisionengine/pull/706>`_: In Jenkins pipeline config use podman instead of docker (@vitodb)
42-
-`DE 712 <https://github.com/HEPCloud/decisionengine/pull/712>`_: Rpm pip packaging with uv and pyproject.toml (@mambelli)
43-
-`DE 714 <https://github.com/HEPCloud/decisionengine/pull/714>`_: Fixed spec file and added release script (@mambelli)
44-
-`DE 715 <https://github.com/HEPCloud/decisionengine/pull/715>`_: Added wrapper to run the decisionengine commands also as root. Fixed installation glitches. (@mambelli)
45-
-`DE 716 <https://github.com/HEPCloud/decisionengine/pull/716>`_: Added a check for the Python code being installed and improved Python code install (@mambelli)
46-
-`DE 717 <https://github.com/HEPCloud/decisionengine/pull/717>`_: Added codespell in pre-commit and fixed files to compliance (@mambelli)
25+
26+
- `DE 668 <https://github.com/HEPCloud/decisionengine/pull/668>`_: Introduce publisher status data product (@knoepfel)
27+
- `DE 671 <https://github.com/HEPCloud/decisionengine/pull/671>`_: explicitly select a container with all our required python versions (@jcpunk)
28+
- `DE 676 <https://github.com/HEPCloud/decisionengine/pull/676>`_: Added EL9 instructions (@mambelli)
29+
- `DE 678 <https://github.com/HEPCloud/decisionengine/pull/678>`_: Updated and tested instructions, PIP installation working (@mambelli)
30+
- `DE 679 <https://github.com/HEPCloud/decisionengine/pull/679>`_: Disabling unit tests for python 3.6 (@vitodb)
31+
- `DE 680 <https://github.com/HEPCloud/decisionengine/pull/680>`_: Make default database init use stronger data protections (@jcpunk)
32+
- `DE 681 <https://github.com/HEPCloud/decisionengine/pull/681>`_: Update to pytest 7 with pytest-postgresql 5 (@jcpunk)
33+
- `DE 682 <https://github.com/HEPCloud/decisionengine/pull/682>`_: Updated EL9 instruction: PIP installation and GWMS config tested (@mambelli)
34+
- `DE 685 <https://github.com/HEPCloud/decisionengine/pull/685>`_: Enable some tests only on DE 1.7 branch (@vitodb)
35+
- `DE 687 <https://github.com/HEPCloud/decisionengine/pull/687>`_: Update GH actions (@vitodb)
36+
- `DE 688 <https://github.com/HEPCloud/decisionengine/pull/688>`_: Added two metrics on the Source - de_source_status and de_source_acquire_seconds (@skylerfoster67)
37+
- `DE 690 <https://github.com/HEPCloud/decisionengine/pull/690>`_: Adding DE EL9 containers based on AlmaLinux9 (@vitodb)
38+
- `DE 691 <https://github.com/HEPCloud/decisionengine/pull/691>`_: Adding Jenkinsfile for EL9 (@vitodb)
39+
- `DE 689 <https://github.com/HEPCloud/decisionengine/pull/689>`_: Added new de-client metrics for duration (@IlyaBaburashvili)
40+
- `DE 694 <https://github.com/HEPCloud/decisionengine/pull/694>`_: Decision Engine Components Data (@skylerfoster67)
41+
- `DE 697 <https://github.com/HEPCloud/decisionengine/pull/697>`_: Redis Exporter Data (@skylerfoster67)
42+
- `DE 703 <https://github.com/HEPCloud/decisionengine/pull/703>`_: Create Redis mock for unit tests (@shreyb)
43+
- `DE 706 <https://github.com/HEPCloud/decisionengine/pull/706>`_: In Jenkins pipeline config use podman instead of docker (@vitodb)
44+
- `DE 712 <https://github.com/HEPCloud/decisionengine/pull/712>`_: Rpm pip packaging with uv and pyproject.toml (@mambelli)
45+
- `DE 714 <https://github.com/HEPCloud/decisionengine/pull/714>`_: Fixed spec file and added release script (@mambelli)
46+
- `DE 715 <https://github.com/HEPCloud/decisionengine/pull/715>`_: Added wrapper to run the decisionengine commands also as root. Fixed installation glitches. (@mambelli)
47+
- `DE 716 <https://github.com/HEPCloud/decisionengine/pull/716>`_: Added a check for the Python code being installed and improved Python code install (@mambelli)
48+
- `DE 717 <https://github.com/HEPCloud/decisionengine/pull/717>`_: Added codespell in pre-commit and fixed files to compliance (@mambelli)
4749

4850
Full list of commits since version 2.0.2
4951
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -207,7 +209,7 @@ Patch level (bug fix) release.
207209
Issues fixed in this release
208210
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
209211

210-
Bugs fixed
212+
Bugs fixed:
211213

212214
- `DE 639 <https://github.com/HEPCloud/decisionengine/issues/639>`_: de-client --status stalls whenever channels are not yet in STEADY state
213215
- `DE 638 <https://github.com/HEPCloud/decisionengine/issues/638>`_: Sources should go offline if the client channel offline

package/release/make-release.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -259,12 +259,12 @@ _main() {
259259
fi
260260
fi
261261

262-
if [[ ",$BUILD_TARGET," = ",rpm," ]]; then
262+
if [[ ",$BUILD_TARGET," = *",rpm,"* ]]; then
263263
# Make the RPM release
264264
release_rpm
265265
fi
266266

267-
if [[ ",$BUILD_TARGET," = ",py," ]]; then
267+
if [[ ",$BUILD_TARGET," = *",py,"* ]]; then
268268
# Make the Python release
269269
release_py
270270
fi

0 commit comments

Comments
 (0)