You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #12893 we added the capability to the health check to ask the topology watcher to reload all the tablets but that is wasteful, because we find that we don't have the primary tablet for a specific shard, we load all the tablets.
For most use-cases this isn't that much of an issue, because we use a single List call to list all the tablets. So the only impact is that we're reading a lot of data that we don't need but nothing else.
Specifically for large customers for 256 shards or so, there are ~750 vttablets, and reading all of these tablet records in List can exceed the maximum data etcd (or other topo server), can send in one go. Following this we read each tablet separately. This is an issue because we end up doing a lot of topo calls, most of which aren't needed.
We should instead only reload the tablets for the keyspace shard in question that we don't have the primary for.
Reproduction Steps
Given in the description
Binary Version
main
Operating System and Environment details
-
Log Fragments
The text was updated successfully, but these errors were encountered:
Overview of the Issue
In #12893 we added the capability to the health check to ask the topology watcher to reload all the tablets but that is wasteful, because we find that we don't have the primary tablet for a specific shard, we load all the tablets.
For most use-cases this isn't that much of an issue, because we use a single
List
call to list all the tablets. So the only impact is that we're reading a lot of data that we don't need but nothing else.Specifically for large customers for 256 shards or so, there are ~750 vttablets, and reading all of these tablet records in
List
can exceed the maximum data etcd (or other topo server), can send in one go. Following this we read each tablet separately. This is an issue because we end up doing a lot of topo calls, most of which aren't needed.We should instead only reload the tablets for the keyspace shard in question that we don't have the primary for.
Reproduction Steps
Given in the description
Binary Version
Operating System and Environment details
Log Fragments
The text was updated successfully, but these errors were encountered: