Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: optionally use sidecar-based heartbeat for ReplicationLagSeconds in health stream #17614

Open
timvaillancourt opened this issue Jan 22, 2025 · 0 comments
Assignees
Labels
Component: VTGate Component: VTTablet Type: Enhancement Logical improvement (somewhere between a bug and feature)

Comments

@timvaillancourt
Copy link
Contributor

timvaillancourt commented Jan 22, 2025

This sub-task discusses using the age of the heartbeat timestamp in the sidecar-based heartbeat (_vt.heartbeat) as the ReplicationLagSeconds in health check stream updates from vttablet

Using this value is more accurate because it:

  • Captures lag when the disk has stalled
  • Captures the lag of the IO + SQL thread executing binlog changes
  • Captures the lag introduced by the network between the replica and primary
@timvaillancourt timvaillancourt self-assigned this Jan 22, 2025
@timvaillancourt timvaillancourt changed the title Optionally use sidecar-based heartbeat for ReplicationLagSeconds in health stream Feature Request: optionally use sidecar-based heartbeat for ReplicationLagSeconds in health stream Jan 29, 2025
@timvaillancourt timvaillancourt added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VTTablet Component: VTGate labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTGate Component: VTTablet Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

No branches or pull requests

1 participant