Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add --force flag for MoveTables / Workflow completion #17517

Open
lizztheblizz opened this issue Jan 13, 2025 · 1 comment
Open
Labels
Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)

Comments

@lizztheblizz
Copy link

Feature Description

Currently, once movetables has executed switchtraffic, and the original source keyspace gets disconnected for any reason, there is no way to force complete it, and the workflow needs to be manually cleaned up from the sidecar db's.

Adding a --force flag to the complete subcommand could allow the proper cleanup to happen even if the workflow outlives the connection to the source keyspace/database.

Use Case(s)

In scenarios where data is being imported into Vitess from an external keyspace, there can be a prolonged period during which the workflow is left after switchtraffic, but before complete, during which the reverse replication streams are kept running.

Sometimes, at that point, the original source database may end up getting removed without having fully cleaned up the Vitess side workflows. Previously, we would have cleaned up there workflows directly with the workflow delete command, but that is also no longer an option in more recent versions of Vitess.

@lizztheblizz lizztheblizz added the Needs Triage This issue needs to be correctly labelled and triaged label Jan 13, 2025
@mattlord
Copy link
Contributor

Just noting that in this scenario the source keyspace would typically be the one with an active workflow (the reverse one). So with --force that could be left in place and be an orphaned set of vreplication streams. This can be documented as one of many reasons that --force should be used with extreme caution.

@mattlord mattlord added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VReplication and removed Needs Triage This issue needs to be correctly labelled and triaged labels Jan 13, 2025
@github-project-automation github-project-automation bot moved this to Backlog in VReplication Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
Status: Backlog
Development

No branches or pull requests

2 participants