Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: escape template tag in CHANGELOG.md #18126

Merged
merged 1 commit into from
Sep 17, 2024
Merged

chore: escape template tag in CHANGELOG.md #18126

merged 1 commit into from
Sep 17, 2024

Conversation

hi-ogawa
Copy link
Collaborator

Description

It looks like this is causing a weird indentation in markdown render:

Screenshots
  • left: before
  • right: after

image

@stackblitz StackBlitz
Copy link

stackblitz bot commented Sep 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@hi-ogawa hi-ogawa marked this pull request as ready for review September 17, 2024 05:12
sapphi-red
sapphi-red approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was aware of the weird indentation but didn't find the cause. Thanks!

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Sep 17, 2024
@sapphi-red sapphi-red merged commit caaa683 into vitejs:main Sep 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hi-ogawa @sapphi-red