Dynamic import syntax errors in 5.3

[cyanzhong]

Describe the bug

There might be a dup closed issue but I suspect I've found more.

I am providing two examples, both from https://github.com/codemirror/language-data but simplified.

// Expected ',', got '[' (Note that you need plugins to import files that are not JavaScript)
function expectedCommaGotSquareBracket(dialect: string) {
  return import("./modules/sql").then(m => m.sql({dialect: (m as any)[dialect]}))
}

// Expected ident (Note that you need plugins to import files that are not JavaScript)
function expectedIdent() {
  return import("./modules/javascript").then(m => m.javascript({jsx: true}))
}

Both can be worked around by translating to async await forms, highly possible to be related to #14221.

Reproduction

...

Steps to reproduce

No response

System Info

System:
    OS: macOS 14.5
    CPU: (10) arm64 Apple M1 Max
    Memory: 8.01 GB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.12.2 - ~/.nvm/versions/node/v20.12.2/bin/node
    Yarn: 1.22.22 - ~/.nvm/versions/node/v20.12.2/bin/yarn
    npm: 10.5.0 - ~/.nvm/versions/node/v20.12.2/bin/npm
    pnpm: 9.3.0 - ~/.nvm/versions/node/v20.12.2/bin/pnpm
  Browsers:
    Edge: 126.0.2592.56
    Safari: 17.5

Used Package Manager

yarn

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[bluwy]

Thanks for the code examples. I figured out the bug. The sql({dialect: (m as any)[dialect] part, which has ({ .... } was tripping out the regex. Will fix this.

[mxschmitt]

Thank you! (this fixes also Playwright component testing)