Inconsistent outcomes when resolving directories with special characters

[zisiszak]

Describe the bug

I kept getting a failed to load config error on an old, archived repo. This repo was nested within a parent directory named old?, whose question mark turned out to be the cause of the error. Only problem is the error is not descriptive, even though a parent directory of old# does alert you that a hash might cause issues.

Renaming the parent directory is an easy fix, and so having a clear error/warning logged suggesting so would help add to an even better dev experience.

I only found three characters that caused that kind of behaviour: ?*\

Reproduction

https://github.com/zisiszak/vite-inconsistent-resolution-error-logging

Steps to reproduce

1. Run cd old\?
2. Run pnpm install (or whatever suits)
3. Run pnpm test (shortcut for pnpm exec vite)

From there, cd into the old# dir and repeat for an example of expected behaviour.

System Info

System:
    OS: macOS 14.5
    CPU: (10) arm64 Apple M1 Max
    Memory: 1.78 GB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.13.1 - ~/.nvm/versions/node/v20.13.1/bin/node
    Yarn: 1.22.22 - ~/.nvm/versions/node/v20.13.1/bin/yarn
    npm: 10.5.2 - ~/.nvm/versions/node/v20.13.1/bin/npm
    pnpm: 9.1.1 - ~/Library/pnpm/pnpm
  Browsers:
    Brave Browser: 125.1.66.118
    Safari: 17.5
  npmPackages:
    vite: ^5.2.13 => 5.2.13

Used Package Manager

pnpm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[bluwy]

We do handle ?

vite/packages/vite/src/node/config.ts

Lines 430 to 432 in a073ac4

	if (path.includes('?')) {
	badChars.push('?')
	}

But seems like for ? the error happened while loading the config, which is too early as we only check the # and ? after the config is loaded. It's strange that # worked for the config, and not ? though. It would be good to check what's causing this.

Otherwise as a last resort we may have to move the bad chars check earlier, at the expense of disregarding the logLevel set in the Vite config.