Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect NODE_ENV value in /guide/env-and-mode #17455

Closed
2 of 4 tasks
Khalifa1997 opened this issue Jun 12, 2024 · 2 comments
Closed
2 of 4 tasks

Incorrect NODE_ENV value in /guide/env-and-mode #17455

Khalifa1997 opened this issue Jun 12, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@Khalifa1997
Copy link

Khalifa1997 commented Jun 12, 2024

Documentation is

  • Missing
  • Outdated
  • Confusing
  • Not sure?

Explain in Detail

import.meta.env.PROD: {boolean} whether the app is running in production (running the dev server with NODE_ENV='production' or running an app built with NODE_ENV='production').

It appears that NODE_ENV='production' is repeated twice here and should be corrected

Your Suggestion for Changes

I believe it should be

import.meta.env.PROD: {boolean} whether the app is running in production (running the dev server with NODE_ENV='development' or running an app built with NODE_ENV='production').

instead

Reproduction

https://vitejs.dev/guide/env-and-mode.html#env-variables

Steps to reproduce

No response

@Khalifa1997 Khalifa1997 added the documentation Improvements or additions to documentation label Jun 12, 2024
@bluwy
Copy link
Member

bluwy commented Jun 13, 2024

I think it's correct since it's talking about import.meta.env.PROD?

@Khalifa1997
Copy link
Author

I think it's correct since it's talking about import.meta.env.PROD?

Ah my bad, thought it would be one about production and the other about development, thank you for responding!

@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants