test(v6): test nested virtual module invalidation #17318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hi-ogawa
force-pushed
the
test-v6-virtual-module-invalidation-nested
branch
from
24d9507
to
ad1af97
Compare
|
I thought this one is still broken, but I just rebased and it turns out tests are passing now. |
|
Ah, I see this is still a draft, @hi-ogawa would you like us to wait before merging? |
|
Forgot it was in draft. I think it makes sense to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Investigating Remix CI and it looks like virtual module invalidation is still not working same when they are nested like this.