-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whether or not module is pre-bundled is highly sensitive to workspace dependencies #17311
Comments
I'm not familiar with npm workspace features, but maybe the difference is just you forgot to run Other than that, the behavior looks same and the issue is essentially #17310. Can you confirm? |
You're right; if I run The main issue is #17310. |
Yeah, I think this one is simply a difference of |
Describe the bug
I'm working on a project with the
@modular-forms/solid
package, which is an ESM module, so I would expect it to not be pre-bundled. However, it's pre-bundled when the following are true (I think).package_a
in my case) does not have the dependencies listed in it's ownpackage.json
; they're listed in the monorepopackage.json
instead.bun
. If you usenpm
, it won't be able to find the right dependencies for some reason.This normally wouldn't be a problem, but it contributed to this issue: #17310.
Reproduction
https://github.com/jsimonrichard/vite-pre-bundling-issues-mre
Steps to reproduce
cd wrongly-pre-bundled/package_a bun i bun start
Then stop the program and inspect
wrongly-pre-bundled/node_modules/.vite
. The pre-bundled file for@modular-forms/solid
should be present.System Info
Used Package Manager
bun
Logs
No response
Validations
The text was updated successfully, but these errors were encountered: