Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomprehensible Node.js version requirement in documentation #16734

Closed
1 of 4 tasks
p-e-w opened this issue May 21, 2024 · 3 comments · Fixed by #17353
Closed
1 of 4 tasks

Incomprehensible Node.js version requirement in documentation #16734

p-e-w opened this issue May 21, 2024 · 3 comments · Fixed by #17353
Labels
contribution welcome documentation Improvements or additions to documentation

Comments

@p-e-w
Copy link

p-e-w commented May 21, 2024

Documentation is

  • Missing
  • Outdated
  • Confusing
  • Not sure?

Explain in Detail

The "Getting Started" guide (https://vitejs.dev/guide/) contains this sentence:

Vite requires Node.js version 18+. 20+.

That doesn't parse. What is the actual requirement? Version 18+? Version 20+? Either? Anything in between?

Your Suggestion for Changes

Make it clear which version is required, using ordinary language.

Reproduction

No response

Steps to reproduce

No response
@p-e-w p-e-w added the documentation Improvements or additions to documentation label May 21, 2024
@bluwy
Copy link
Member

bluwy commented May 27, 2024

v18+ or v20+. v19 is not supported though could work.

@p-e-w
Copy link
Author

p-e-w commented May 28, 2024

Is . a commonly used notation for "or" then, or is that just a typo?

@bluwy
Copy link
Member

bluwy commented May 28, 2024

Just a typo

@younggglcy younggglcy mentioned this issue May 30, 2024
Merged
bluwy pushed a commit that referenced this issue May 31, 2024
@younggglcy
docs(guide): clarify Node.js version requirement (fix #16734) (#17353)
147e922
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contribution welcome documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(guide): clarify Node.js version requirement (fix #16734) younggglcy/vite
2 participants
@p-e-w @bluwy