fix(sourcemap): improve sourcemap compatibility for vue2 #16594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
amweiss
changed the title
sapphi-red
changed the title
sapphi-red
changed the title
sapphi-red
added
p2-edge-case
sapphi-red
approved these changes
May 5, 2024
patak-dev
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change does match what was in #16192 but that is marked as not resolving a different problem, so I didn't want to conflate things.
Thile using vue2, and specifically the
vue2-google-mapspackage which contains a vue component, the build process produces aresolvedSourcePaththat contains query string style arguements such as:/home/adam/repos/vue2-map/node_modules/node_modules/.pnpm/[email protected]/node_modules/vue2-google-maps/dist/components/placeInputImpl.js?v=c006e476&vue&type=script&src=true&lang.jsThis then leads to a
missingSourcesentry since the characters after the extension do not allow for the file to be loaded such as:By first converting the URI to a filesystem path, we can ensure it loads the file.