Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate VTK8 patches for VTK 9 (vtkOpenglSphereMapper, vtkOpenFoamReader) #19475

Closed
1 task
biagas opened this issue Apr 30, 2024 · 2 comments
Closed
1 task
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@biagas
Copy link
Contributor

biagas commented Apr 30, 2024

There were patches for the vtkOpenGLSphereMapper and vtkOpenFoamReader classes with VTK 8.
The code base changed significantly enough it couldn't be easily determined if a patch was still needed.

These should be investigated, and new patches created if needed.

  • [ ] vtkOpenGLSphereMapper
  • vtkOpenFOAMReader
@biagas biagas added the enhancement New feature or request label Apr 30, 2024
@biagas biagas self-assigned this Apr 30, 2024
@biagas biagas added this to the 3.4.2 milestone Apr 30, 2024
@biagas
Copy link
Contributor Author

biagas commented May 17, 2024

vtkOpenGLSphereMapper : seems to not need a patch with 9.2.6.
When rendering point meshes whose coordinates are very large or very small, and using the 'Sphere' glyph type (sphere imposters), the PointSize must match the scale of the coordinates. An Auto point size would be helpful in these instances. See #18818

@biagas
Copy link
Contributor Author

biagas commented May 17, 2024

vtkOpenFOAMReader patches not needed. We have our own. They need updating, however. Will open a new ticket for that.

@biagas biagas closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant