Skip to content

Commit

Permalink
Upgrade versions of dependencies and bump to v0.0.6 (#17)
Browse files Browse the repository at this point in the history
This fixes #16 which was a duplicate of fent/node-ytdl-core#287.
Upgrading "ytdl-core" to "0.20.2" solved it.
Meanwhile, ugraded other dependencies as well.
The upgraded "check-node-version" NPM package's API seems to be changed, therefore needed to update "lib/prerequisites_checker.js" accordingly.

Bumped the version to v0.0.6
  • Loading branch information
Vishal Telangre authored Apr 7, 2018
1 parent fc24c36 commit c4a54ef
Show file tree
Hide file tree
Showing 4 changed files with 487 additions and 272 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ in future.

### Installation

Please make sure that you have `node v6.x` or latest
and
Please make sure that you have `node v6.x` or latest
and
`npm v5.x` or latest versions installed on your machine.

```
Expand Down Expand Up @@ -81,6 +81,6 @@ It then downloads the matching music from YouTube.

### Copyright and License

Copyright (c) 2017, Vishal Telangre. All Rights Reserved.
Copyright (c) 2017-2018, Vishal Telangre and Contributors. All Rights Reserved.

This project is licenced under the [MIT License](LICENSE.txt).
12 changes: 7 additions & 5 deletions lib/prerequisites_checker.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,21 @@ function PrerequisitesChecker(callback) {
// here - https://github.com/vishaltelangre/music-dl/issues/5
// and here: https://github.com/vishaltelangre/music-dl/issues/4.
check({ node: ">= 6.3.1", npm: ">= 5.0.3" }, {}, function (err, result) {
var versions = result.versions || {};

if (err) console.error(err);

var printErrorIfVersionNotSatisfied = function (tool) {
if (result[tool].isSatisfied) return;
if (versions[tool].isSatisfied) return;

var message = "✗ Please upgrade `"
+ tool.bold
+ "` to version "
+ result[tool].wanted.range.bold
+ versions[tool].wanted.range.bold
+ " or latest. Current "
+ tool
+ " version is "
+ result[tool].version
+ versions[tool].version
+ ".";

console.error(message.red)
Expand All @@ -28,8 +30,8 @@ function PrerequisitesChecker(callback) {
printErrorIfVersionNotSatisfied('node');
printErrorIfVersionNotSatisfied('npm');

if (result.node.isSatisfied &&
result.npm.isSatisfied &&
if (versions.node.isSatisfied &&
versions.npm.isSatisfied &&
(typeof callback === "function")) {
callback();
}
Expand Down
20 changes: 10 additions & 10 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "git",
"url": "https://github.com/vishaltelangre/music-dl"
},
"version": "0.0.5",
"version": "0.0.6",
"description": "Download audio song playlists/albums from multiple song providers!",
"main": "index.js",
"author": "Vishal Telangre <[email protected]>",
Expand All @@ -13,17 +13,17 @@
"music-dl": "./index.js"
},
"dependencies": {
"check-node-version": "^2.1.0",
"check-node-version": "^3.2.0",
"cli": "^1.0.1",
"colors": "^1.1.2",
"colors": "^1.2.1",
"fluent-ffmpeg": "^2.1.2",
"lodash": "^4.17.4",
"lodash": "^4.17.5",
"mkdirp": "^0.5.1",
"node-id3": "^0.0.9",
"osmosis": "^1.1.4",
"promise": "^7.3.0",
"update-notifier": "^2.2.0",
"youtube-search": "^1.0.10",
"ytdl-core": "^0.14.4"
"node-id3": "^0.1.3",
"osmosis": "^1.1.6",
"promise": "^8.0.1",
"update-notifier": "^2.4.0",
"youtube-search": "^1.1.0",
"ytdl-core": "^0.20.2"
}
}
Loading

0 comments on commit c4a54ef

Please sign in to comment.