Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double the number of silent samples may be written per SilentAudioFrame packet received. #1708

Open
ctrlaltdavid opened this issue Oct 12, 2022 · 1 comment
Open

Double the number of silent samples may be written per SilentAudioFrame packet received. #1708

ctrlaltdavid opened this issue Oct 12, 2022 · 1 comment
Labels
bug Something isn't working stale Issue / PR has not had activity

Comments

@ctrlaltdavid
Copy link
Collaborator

The value being passed into InboundAudioStream::writeDroppableSilentFrames(int silentFrames) is the number of silent samples (480 for stereo), not the number of silent frames (240 for stereo). The code then doubles this number for stereo to calculate the number of silent samples.

The result is that too much silence is added. However, because silence is only added if the jitter buffer is less than its desirable size, typically the extra silence will be discarded (dropped) and not written.

A benign bug but confusing code.
@ctrlaltdavid ctrlaltdavid added the bug Something isn't working label Oct 12, 2022
@stale
Copy link

stale bot commented Apr 11, 2023

Hello! Is this still an issue?

@stale stale bot added the stale Issue / PR has not had activity label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working stale Issue / PR has not had activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctrlaltdavid