Change dryRun variable to false, make mac_address field optional on application network answerfile section (#36)

* Application network is no longer mandatory on answerfile, change cloyster.h dryRun variable to false by default

Signed-off-by: lbgracioso <[email protected]>

* Add user confirmation to run the project

Signed-off-by: lbgracioso <[email protected]>

* Change to while loop on unattended confirmation

Signed-off-by: lbgracioso <[email protected]>

---------

Signed-off-by: lbgracioso <[email protected]>

Author: lbgracioso

include/cloysterhpc/cloyster.h

@@ -14,7 +14,7 @@
 namespace cloyster {
 bool showVersion = false;
 bool runAsRoot = false;
-bool dryRun = true;
+bool dryRun = false;
 bool enableTUI = false;
 bool enableCLI = false;
 bool runAsDaemon = false;

src/answerfile.cpp

@@ -165,7 +165,7 @@ void AnswerFile::loadApplicationNetwork()
     }
 
     application.con_mac_addr
-        = m_ini.getValue("network_application", "mac_address", false);
+        = m_ini.getValue("network_application", "mac_address");
 
     try {
         application.subnet_mask = convertStringToAddress(

src/cluster.cpp

@@ -577,8 +577,10 @@ void Cluster::fillData(const std::string& answerfilePath)
         auto applicationConnection
             = Connection(&getNetwork(Network::Profile::Application));
 
-        applicationConnection.setMAC(
-            answerfile.application.con_mac_addr.value());
+        if (!answerfile.application.con_mac_addr->empty()) {
+            applicationConnection.setMAC(
+                answerfile.application.con_mac_addr.value());
+        }
 
         applicationConnection.setInterface(
             answerfile.application.con_interface.value());

src/main.cpp

@@ -75,6 +75,10 @@ int main(int argc, const char** argv)
     app.add_option(
         "-a, --answerfile", cloyster::answerfile, "Full path to a answerfile");
 
+    bool unattended = false;
+    app.add_flag(
+        "-u, --unattended", unattended, "Perform an unattended installation");
+
     CLI11_PARSE(app, argc, argv)
 
     Log::init([]() {
@@ -96,6 +100,22 @@ int main(int argc, const char** argv)
     LOG_INFO("{} Started", productName);
 
     try {
+        while (!unattended) {
+            char response = 'N';
+            fmt::print("{} will now modify your system, do you want to "
+                       "continue? [Y/N]\n",
+                cloyster::productName);
+            std::cin >> response;
+
+            if (response == 'Y' || response == 'y') {
+                LOG_INFO("Running {}.\n", cloyster::productName)
+                break;
+            } else if (response == 'N' || response == 'n') {
+                LOG_INFO("Stopping {}.\n", cloyster::productName);
+                return EXIT_SUCCESS;
+            }
+        }
+
         if (cloyster::showVersion) {
             fmt::print("{}: Version {}\n", productName, productVersion);
             return EXIT_SUCCESS;