Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallibleParsedData doesn't support GPX 1.0 parsing #96

Open
OlKir opened this issue May 25, 2022 · 2 comments
Open

fallibleParsedData doesn't support GPX 1.0 parsing #96

OlKir opened this issue May 25, 2022 · 2 comments
Labels
enhancement New feature or request parsing Something about the parser isn't working

Comments

@OlKir
Copy link

OlKir commented May 25, 2022

Thank you for maintaining a great and useful library!
I was happy to see that it now also supports GPX 1.0 files but my first attempts to parse one failed.

Looking into the code I found that flow to parse legacy GPX was added to parsedData() but fallibleParsedData(forceContinue: Bool) still contains hard check for 1.1 version.

I prefer to use fallibleParsedData as it throws error messages and could handle slightly disordered data. And I would be grateful if you add support for 1.0 parsing there as well.

@vincentneo
Copy link
Owner

Hi @OlKir,

Been a while since I touched the code on this v1 support, I think currently only .legacyParsingData() parses that for now. (if I recall correctly)

And yes, this brings up a good point where there isn't feature consistency when parsing between these gpx versions, which is something that I should work on.

Thanks for sending this issue in!

@vincentneo vincentneo added enhancement New feature or request parsing Something about the parser isn't working labels May 25, 2022
@john-work-ios
Copy link

Just ran into this as well! :-) I'll be moving to parsedData() for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request parsing Something about the parser isn't working
Projects
None yet
Development

No branches or pull requests

3 participants