Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better database permission management #500

Open
vincent-peugnet opened this issue Jan 14, 2025 · 0 comments
Open

better database permission management #500

vincent-peugnet opened this issue Jan 14, 2025 · 0 comments
Labels
enhancement New feature or request security

Comments

@vincent-peugnet
Copy link
Owner

This do not allow to set the permission in the parent folder (database folder). It only control the repository folder.

https://github.com/vincent-peugnet/wcms/blob/deef55a8b425d040fca902f305e571bc6f34894a/app/class/Flywheel/Repository.php#L10C1-L21C1

Flywheel use a default hard-coded 777 recursively. Which set the permission for any parent subfolders that it needs to create.

https://github.com/jamesmoss/flywheel/blob/001a7bba01ad537d119853cd86078b1b51540daf/src/JamesMoss/Flywheel/Repository.php#L39

Besides, it could be better to set the permissions only once during folder creation instead of doing chmod each time construct() is called.
@vincent-peugnet vincent-peugnet added enhancement New feature or request security labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vincent-peugnet