-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing trailing slash in page context url #1632
Conversation
I'm not sure how we can proceed with |
What's the issue? Can you rebase on top of `git fetch; git rebase -i
origin/main`?
…On Thu, May 2, 2024 at 2:55 PM Robin ***@***.***> wrote:
I'm not sure how we can proceed with /en/index.pageContext.json/.
Requests fetching page contexts fail.
—
Reply to this email directly, view it on GitHub
<#1632 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHVQRQNMFIEK57N6JN2DG3ZAIZTJAVCNFSM6AAAAABHDU5A3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJQGQZTIMJSHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
2c00177
to
2f22edd
Compare
2f22edd
to
80be506
Compare
So far:
I will follow that lead now. |
@openscript Makes sense 👍 |
Where would be a good place to update the |
Actually, what we need is the other way around: we need the client to tell the server that the URL has a trailing slash. So I'm not sure |
How about this then:
|
We can then use |
Is my thinking about the solution wrong? Maybe it's better if you take over this issue. I feel a bit lost with it. |
The client-side is the source of truth. So the bottom line here is that the information needs to be communicated from the client to the server. I thought more about it and I'm afraid there doesn't seem to a solution. The issue is that pre-rendering requires the |
fixes #1629