minor refactor

Author: brillout

vike/shared/page-configs/getUserFriendlyConfigs.ts

@@ -15,6 +15,7 @@ import type { FileType } from '../getPageFiles/fileTypes.js'
 import type { PageFile } from '../getPageFiles/getPageFileObject.js'
 import type {
   ConfigValues,
+  DefinedAtData,
   PageConfigBuildTime,
   PageConfigGlobalRuntime,
   PageConfigRuntime,
@@ -310,12 +311,10 @@ function getUserFriendlyConfigs_V1Design(pageConfig: { configValues: ConfigValue
     sources[configName]!.push(src)
   }
 
-  const addLegacy = (
-    configName: string,
-    value: unknown,
-    configDefinedAt: ConfigDefinedAtOptional,
-    configValueFilePathToShowToUser: string | null
-  ) => {
+  const addLegacy = (configName: string, value: unknown, definedAtData: DefinedAtData) => {
+    const configValueFilePathToShowToUser = getConfigValueFilePathToShowToUser(definedAtData)
+    const configDefinedAt = getConfigDefinedAtOptional('Config', configName, definedAtData)
+
     configEntries[configName] = configEntries[configName] ?? []
     // Currently each configName has only one entry. Adding an entry for each overriden config value isn't implemented yet. (This is an isomorphic file and it isn't clear whether this can/should be implemented on the client-side. We should load a minimum amount of code on the client-side.)
     assert(configEntries[configName]!.length === 0)
@@ -340,8 +339,6 @@ function getUserFriendlyConfigs_V1Design(pageConfig: { configValues: ConfigValue
 
   Object.entries(pageConfig.configValues).forEach(([configName, configValue]) => {
     const { value } = configValue
-    const configValueFilePathToShowToUser = getConfigValueFilePathToShowToUser(configValue.definedAtData)
-    const configDefinedAt = getConfigDefinedAtOptional('Config', configName, configValue.definedAtData)
 
     config[configName] = config[configName] ?? value
 
@@ -379,7 +376,7 @@ function getUserFriendlyConfigs_V1Design(pageConfig: { configValues: ConfigValue
       from.configsComputed[configName] = src
     }
 
-    addLegacy(configName, value, configDefinedAt, configValueFilePathToShowToUser)
+    addLegacy(configName, value, configValue.definedAtData)
   })
 
   return {