Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to profile the ecc measurement code #52

Open
vijayvarma392 opened this issue May 21, 2022 · 4 comments
Open

We need to profile the ecc measurement code #52

vijayvarma392 opened this issue May 21, 2022 · 4 comments
Assignees
Labels
high priority critical issue

Comments

@vijayvarma392
Copy link
Owner

Would be good to understand which part of the code is slowest, etc.

@vijayvarma392
Copy link
Owner Author

Here's something that would be nice for the paper:
For waveforms with approx params of GW150914 and GW170817, run the different methods and document the costs in a table. The reason this would be nice is we can say in the paper how much extra cost is involved in our postprocessing.

For this, I would write a script and add it to gw_eccentricity/EccTests/TimingTests so that the test can be run repeatedly as we make improvements.

@vijayvarma392
Copy link
Owner Author

vijayvarma392 commented Nov 25, 2022

This also sounds like higher priority, but as time permits. More important than the table for the paper is to run a python profiler and see if there are bottlenecks that can be avoided.

@vijayvarma392 vijayvarma392 added medium priority inbetweener and removed low priority noncritical issue labels Jan 31, 2023
@vijayvarma392
Copy link
Owner Author

@md-arif-shaikh: I think this is probably a high priority item now, as we get ready to review gw_ecc. We need to understand:

  1. How fast is the gw_ecc evaluation time for a single waveform for a 20 orbit signal and a 100 orbit signal.
  2. Which part of the code is dominating the cost? Can that be improved with some optimization?
  3. Should we only compute ecc using a small segment of the signal? What is the error introduced by this?

@md-arif-shaikh
Copy link
Collaborator

md-arif-shaikh commented Jun 6, 2024

@vijayvarma392 sure I will check this out. I will work on it after #215 is merged.

@md-arif-shaikh md-arif-shaikh added high priority critical issue and removed medium priority inbetweener labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority critical issue
Projects
None yet
Development

No branches or pull requests

2 participants