Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handing failures due to eccentricity decay #206

Open
md-arif-shaikh opened this issue Oct 17, 2023 · 0 comments
Open

Handing failures due to eccentricity decay #206

md-arif-shaikh opened this issue Oct 17, 2023 · 0 comments

Comments

@md-arif-shaikh
Copy link
Collaborator

PR #203 addresses #84 when no sufficient extrema are not found and we can not build interpolants through the pericenters and apocenters. However, there would be cases where we can find enough extrema in the initial part of the waveform and therefore build the interpolants but due to decay of eccentricity the last pericenters/apocenters may be far from the merger. In such cases, if tref_in is later than the last pericenters/apocenters, eccentricity measurement will fail. We need to handle such failures also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant