Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using moving average as the mean amplitude to find residual amplitude #125

Open
md-arif-shaikh opened this issue Aug 12, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request future work Gotta postpone some

Comments

@md-arif-shaikh
Copy link
Collaborator

This could be an optional method that we can add later to the library.

Idea

  • This is nothing new. We have discussed this more than once before deciding to use the quasicircular amplitude as reference amplitude to subtract from the eccentric amplitude to get the residual amplitude which we use to find the location of the extrema.
  • The idea is to use a moving average of the amplitude itself. The problem is that we need a picture of the window (let's say over an orbit) in terms of the sample points around a given data point where we want to compute the moving average. One can get an idea of the window by seeking the number of indices over which $\phi_{22}$ changes by a $4\pi$. However, we also need to be careful about the pericenter advancement which could change the averaging non-trivially.

Basic Implementation

  • Over the last couple of days I tried to add a module to our library based on this idea. I am able to get a decent working method. Below I attach two plots from eob tests over one parameter set.
  • Currently, it's on a branch on my local machine. will push it at some point so that it could be polished and improved later.

test_eob_vs_measured_ecc_set3_ResidualAmplitude_MovingAmplitudeAverage.pdf
test_measured_ecc_vs_time_set3_ResidualAmplitude_MovingAmplitudeAverage.pdf

This issue to come back to this in the future.

@md-arif-shaikh md-arif-shaikh self-assigned this Aug 12, 2022
@md-arif-shaikh md-arif-shaikh added future work Gotta postpone some enhancement New feature or request labels Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request future work Gotta postpone some
Projects
None yet
Development

No branches or pull requests

1 participant