Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

klipse_plugin_min.js global variable issue #370

Open
rdbeach opened this issue Jun 11, 2020 · 1 comment
Open

klipse_plugin_min.js global variable issue #370

rdbeach opened this issue Jun 11, 2020 · 1 comment

Comments

@rdbeach
Copy link

rdbeach commented Jun 11, 2020

It appears that the minified version of the plugin contains several short global variables, among them "io", which is also used globally by socket.io. Using both files at the same time causes a variable naming conflict and will ultimately cause socket.io to break. I temporarily resolved this issue by simply renaming "io".

Is it ok to wrap the klipse plugin in a closure to prevent these variables from having global scope? Or will that cause other things to break?

@viebel
Copy link
Owner

viebel commented Jun 11, 2020

It should be ok to wrap the klipse plugin in a closure.
Can you open a PR for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants