Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Klipse 7.7.1 exposes globals to window #330

Open
polytypic opened this issue Dec 19, 2018 · 7 comments
Open

Klipse 7.7.1 exposes globals to window #330

polytypic opened this issue Dec 19, 2018 · 7 comments

Comments

@polytypic
Copy link
Contributor

Hmm... It seems that Klipse 7.7.1 writes its globals with minimized names to the window object. This breaks all of my Klipse based pages as they expose a few JavaScript libraries with short names like R and L to the window for the snippets to use. With 7.7.1 those names are overwritten by Klipse and the snippets no longer work. For example, the Fastener library page is broken. If you open the browser console run Object.keys(window) and inspect the result you can see the exposed globals.

@viebel
Copy link
Owner

viebel commented Dec 19, 2018

This is annoying.
As far as I can see, R was also used by Klipse 7.6.9, deployed last week.
Are you sure this is a new bug caused by 7.7.1, deployed today?

@viebel
Copy link
Owner

viebel commented Dec 19, 2018

You can try oldest Klipse version following the instructions here

@polytypic
Copy link
Contributor Author

Are you sure this is a new bug caused by 7.7.1, deployed today?

Yesterday morning I happened to hold a presentation where I used a Klipse powered playground. This morning I noticed that the playground no longer worked (IOW, that R and other libraries exposed to the playground code snippet had been overwritten).

@viebel
Copy link
Owner

viebel commented Dec 19, 2018

OK. I will look at it further. Do yo want to use a previous version until I am fixing the bug?
See https://github.com/viebel/klipse#use-older-versions

@polytypic
Copy link
Contributor Author

Thanks! There is no hurry. I might try pinning the Klipse version this evening.

@viebel
Copy link
Owner

viebel commented Jan 10, 2019

One temporary workaround would be to use the non-minified version of Klipse.

@polytypic
Copy link
Contributor Author

Check. FYI, I have now pinned the Klipse version to 7.6.9 in most places where I’ve used Klipse. I will likely use explicit versioning of Klipse in the future - which of course makes sense anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants